Conversation
|
@gitsabari note, previously code branch with port isolation group was dead and port isolation group was not used. |
|
@lguohan could you please review it? |
|
@qiluo-msft could you please review it? |
|
@lguohan could you please review it? |
|
@qiluo-msft could you please review it? |
|
@gechiang could you please review it? |
|
@gitsabari, @Praveen-Brcm , please take a look |
|
@lguohan could you please help to review it? |
|
Looks good to me. But let's wait for @gitsabari, @Praveen-Brcm to review and approve. |
|
Changes looks good to me. Please add me to the reviwers list to approve. Thanks. |
@Praveen-Brcm |
|
changes looks good to me also. Please add me to reviewer list to approve |
gechiang
left a comment
gechiang
left a comment
There was a problem hiding this comment.
LGTM! @Praveen-Brcm has also reviewed and approved.
5 participants
Why I did it
mclagsyncdsource is in sonic-swss repo, its binary is insideiccpdcontainer and binary useplatformenv var https://github.com/Azure/sonic-swss/blob/ef6b5d48297f7f19a8ec57e2d7b997fd0919bb9d/mclagsyncd/mclaglink.cpp#L191But
platformenv is set only insideswsscontainer services, for example https://github.com/Azure/sonic-buildimage/blob/7d40384c58848c368ecf7b2c520f7a17fcbc8bdb/dockers/docker-orchagent/orchagent.sh#L7So code doesn't support branch with port isolation group, because env is not set.
How I did it
Added env to iccpds start script, like in
orchagentHow to verify it
Delete all isolation group destination ports, hence code branch with port isolation group was used instead of ACLWhich release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)