[hostcfgd] Fix the delay type to 'boot' delay instead of a unit activation delay#8895
Merged
renukamanavalan merged 1 commit intosonic-net:masterfrom Oct 20, 2021
shlomibitton:shlomi_hostcfgd_delay_master
Merged
[hostcfgd] Fix the delay type to 'boot' delay instead of a unit activation delay#8895renukamanavalan merged 1 commit intosonic-net:masterfrom shlomibitton:shlomi_hostcfgd_delay_master
renukamanavalan merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_hostcfgd_delay_master
Conversation
Signed-off-by: Shlomi Bitton <[email protected]>
Contributor
Author
|
@dgsudharsan can you please review? |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Oct 4, 2021
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@lguohan Can you please review and signoff? |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
5 tasks
renukamanavalan
approved these changes
Oct 19, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 21, 2021
Why I did it With current code the delay will take place even if simple 'config reload' command executed and this is not desired. This delay should be used only when fast-rebooting. How I did it Change the type of delay to OnBootSec instead of OnActiveSec. How to verify it Fast-reboot with this PR and observe the delay. Run 'config-reload' command and observe no delay is running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton [email protected]
Why I did it
With current code the delay will take place even if simple 'config reload' command executed and this is not desired.
This delay should be used only when fast-rebooting.
How I did it
Change the type of delay to OnBootSec instead of OnActiveSec.
How to verify it
Fast-reboot with this PR and observe the delay.
Run 'config-reload' command and observe no delay is running.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)