Load global config in caclmgrd only in multi asic NPU#8812
Merged
arlakshm merged 1 commit intosonic-net:masterfrom Sep 30, 2021
Merged
Load global config in caclmgrd only in multi asic NPU#8812arlakshm merged 1 commit intosonic-net:masterfrom
arlakshm merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
Author
|
@arlakshm @judyjoseph Please review |
Collaborator
Author
|
@arlakshm @judyjoseph @lguohan Can we merge this if changes are good? |
yxieca
pushed a commit
that referenced
this pull request
Oct 4, 2021
How I did it Added if multi npu check before invoking the load global config. How to verify it Restart caclmgrd after this change and check if no error log is thrown.
judyjoseph
pushed a commit
that referenced
this pull request
Oct 5, 2021
How I did it Added if multi npu check before invoking the load global config. How to verify it Restart caclmgrd after this change and check if no error log is thrown.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The database_global.json file is generated only in multi asic scenario. However, caclmgrd calls initialization based on this file without multi npu check.
This leads to following error in single asic scenario
Sep 21 22:35:20.996798 r-leopard-32 ERR caclmgrd[11819]: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json
How I did it
Added if multi npu check before invoking the load global config.
How to verify it
Restart caclmgrd after this change and check if no error log is thrown.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)