-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[TACACS+] Add Bash TACACS+ plugin for per-command authorization. #8715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
00e9867
[TACACS+]: Add TACACS support library and fix memory leak issue.
liuh-80 7dcf307
Add Bash TACACS+ plugin.
liuh-80 fff5f0c
Improve code.
liuh-80 dcc782b
Fix code according to discussion and PR comments.
liuh-80 d90e0c8
Fix PR comments
liuh-80 b53c4f8
Improve code by PR comments.
liuh-80 22cfd79
Fix make file
8d70ebb
Merge remote-tracking branch 'origin/master' into dev/liuh/bash_tacplus
liuh-80 db26d95
Build package with dpkg-buildpackage
liuh-80 829b0df
Merge remote-tracking branch 'origin' into dev/liuh/bash_tacplus
liuh-80 cc496f4
Improve bash plugin code.
liuh-80 a729bb6
Fix parse /etc/tacplus_nss.conf issue. also fix server list not clean…
liuh-80 3bcd3c4
Fix some missing change caused by git history cleanup for PR review.
liuh-80 00be3e2
Fix PR comments.
liuh-80 6a89731
Improve patch file.
liuh-80 60d70b2
Add post-install script to update bash config file.
liuh-80 36af0f9
Merge remote-tracking branch 'origin' into dev/liuh/bash_tacplus
liuh-80 1e24fe8
Fix the bash plugin not installed issue.
liuh-80 5376bb1
Fix bash tacacs plugin build rule.
liuh-80 29bef8d
Fix make file issue.
liuh-80 5c9cd95
Change bash_tacplus build rule to SONIC_DPKG_DEBS because no need to …
liuh-80 7f3366b
Update patch file according PR comments.
liuh-80 d4e9e0c
Fix patched version of bash not installed issue.
liuh-80 9cba880
Fix parse debug flag in config file issue.
liuh-80 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| * | ||
| !.gitignore | ||
| bash/* | ||
| !bash/Makefile | ||
| !bash/bash_tacplus/* | ||
| nsm/* | ||
| !nsm/Makefile | ||
| !nsm/*.patch | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| .ONESHELL: | ||
| SHELL = /bin/bash | ||
| .SHELLFLAGS += -e | ||
|
|
||
| MAIN_TARGET = bash-tacplus_$(NSS_TACPLUS_VERSION)_$(CONFIGURED_ARCH).deb | ||
|
|
||
| $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% : | ||
| pushd ./bash_tacplus | ||
|
|
||
| # config source code | ||
| autoreconf | ||
| ./configure | ||
|
liuh-80 marked this conversation as resolved.
Outdated
|
||
|
|
||
| # build bash_tacplus | ||
| make | ||
| dpkg-buildpackage -rfakeroot -b -us -uc -j$(SONIC_CONFIG_MAKE_JOBS) --admindir $(SONIC_DPKG_ADMINDIR) | ||
|
|
||
| # run UT after build package | ||
| make -C unittest && make test -C unittest | ||
|
|
||
| popd | ||
|
|
||
| mv $(DERIVED_TARGETS) $* $(DEST)/ | ||
|
|
||
| $(addprefix $(DEST)/, $(DERIVED_TARGETS)): $(DEST)/% : $(DEST)/$(MAIN_TARGET) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| ########################################################################### | ||
| ## | ||
| ## File: ./Makefile.am | ||
| ## Versions: $Id: Makefile.am,v 1.0 2021/08/24 12:04:29 liuh@microsoft.com Exp $ | ||
| ## Created: 2021/08/24 | ||
| ## | ||
| ########################################################################### | ||
|
|
||
| ACLOCAL_AMFLAGS = -I config | ||
| AUTOMAKE_OPTIONS = subdir-objects | ||
|
|
||
| moduledir = @plugindir@ | ||
| module_LTLIBRARIES = bash_tacplus.la | ||
| bash_tacplus_la_SOURCES = bash_tacplus.h \ | ||
| bash_tacplus.c | ||
| bash_tacplus_la_CFLAGS = $(AM_CFLAGS) -I $(top_srcdir)/libtac/include | ||
| bash_tacplus_la_LDFLAGS = -module -avoid-version | ||
|
|
||
| EXTRA_DIST = bash_tacplus.spec | ||
|
|
||
| MAINTAINERCLEANFILES = Makefile.in config.h.in configure aclocal.m4 \ | ||
| config/config.guess config/config.sub config/depcomp \ | ||
| config/install-sh config/ltmain.sh config/missing | ||
|
|
||
| pkgconfigdir = $(libdir)/pkgconfig | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.