Removing execute permission from copp service file#8680
Merged
prsunny merged 1 commit intosonic-net:masterfrom Sep 13, 2021
Merged
Removing execute permission from copp service file#8680prsunny merged 1 commit intosonic-net:masterfrom
prsunny merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
Author
|
@prsunny Please review |
prsunny
approved these changes
Sep 3, 2021
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
Request for 202106 and 202012 Branches |
Collaborator
Author
|
@prsunny Can you please merge this? |
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 14, 2021
*Removed execute permissions from the systemd copp-config.service file. Without this we will get a warning: "Configuration file /lib/systemd/system/copp-config.service is marked executable. Please remove executable permission bits. Proceeding anyway."
judyjoseph
pushed a commit
that referenced
this pull request
Sep 14, 2021
*Removed execute permissions from the systemd copp-config.service file. Without this we will get a warning: "Configuration file /lib/systemd/system/copp-config.service is marked executable. Please remove executable permission bits. Proceeding anyway."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To fix the issue #8581
Removed execute permissions from the systemd copp-config.service file. Without this we will get a warning
Aug 25 06:36:43.738669 r-anaconda-51 WARNING systemd[1]: Configuration file /lib/systemd/system/copp-config.service is marked executable. Please remove executable permission bits. Proceeding anyway.
How I did it
Changed file permissions
How to verify it
find files/image_config/ -name "*".service | xargs ls -l
-rw-r--r-- 1 sudharsand dip 196 May 4 03:06 files/image_config/copp/copp-config.service
-rw-r--r-- 1 sudharsand dip 231 May 4 03:06 files/image_config/corefile_uploader/core_uploader.service
-rw-r--r-- 1 sudharsand dip 135 May 4 03:06 files/image_config/fstrim/fstrim.service
-rw-r--r-- 1 sudharsand dip 263 May 4 03:06 files/image_config/hostname/hostname-config.service
-rw-r--r-- 1 sudharsand dip 263 May 4 03:06 files/image_config/interfaces/interfaces-config.service
-rw-r--r-- 1 sudharsand dip 292 May 4 03:06 files/image_config/ntp/ntp-config.service
-rw-r--r-- 1 sudharsand dip 418 May 4 03:06 files/image_config/ntp/ntp.service
-rw-r--r-- 1 sudharsand dip 216 Jun 16 21:31 files/image_config/pcie-check/pcie-check.service
-rw-r--r-- 1 sudharsand dip 257 May 4 03:06 files/image_config/rsyslog/rsyslog-config.service
-rw-r--r-- 1 sudharsand dip 233 May 4 03:06 files/image_config/system-health/system-health.service
-rw-r--r-- 1 sudharsand dip 283 May 4 03:06 files/image_config/topology/topology.service
-rw-r--r-- 1 sudharsand dip 229 May 4 03:06 files/image_config/warmboot-finalizer/warmboot-finalizer.service
-rw-r--r-- 1 sudharsand dip 169 May 4 03:06 files/image_config/watchdog-control/watchdog-control.service
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)