Configure midplane interface in multi-asic namespaces on a chassis#8583
Merged
rlhui merged 1 commit intosonic-net:masterfrom Oct 27, 2021
Merged
Configure midplane interface in multi-asic namespaces on a chassis#8583rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
judyjoseph
reviewed
Aug 31, 2021
judyjoseph
reviewed
Aug 31, 2021
Contributor
|
Thanks for the PR. Could you update the PR description with more details like ip route o/p in namespace/host , arp entries learned etc on a linecard as well as supervisor card. |
Contributor
|
@arlakshm @abdosi @minionatwork could you take a look as well |
Contributor
Author
Description updated with requested output. |
|
Looks good to me. |
Arista-Jenkins
pushed a commit
to aristanetworks/sonic
that referenced
this pull request
Oct 1, 2021
As per discussions with Microsoft and sonic-buildimage PR8583 (sonic-net/sonic-buildimage#8583), we are renaming the midplane interface from eth0.$VLAN_ID to eth1-midplane. Change-Id: I2ae2188611a8018fc8d81ad0b3c3e1e58d6a48c3
…s DB Add code to interfaces-config.sh to configure eth1 in multi-asic containers so that they can access midplane subnet.
784144a to
c958912
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
It looks good to me |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
approved these changes
Oct 26, 2021
Contributor
|
Is there a particular reason the midplane interface name has to be 'eth1-midplane'? Could this be platform defined in chassisd.conf and sourced in interfaces-config.sh? |
Arista-Jenkins
pushed a commit
to aristanetworks/sonic
that referenced
this pull request
Dec 9, 2021
As per discussions with Microsoft and sonic-buildimage PR8583 (sonic-net/sonic-buildimage#8583), we are renaming the midplane interface from eth0.$VLAN_ID to eth1-midplane. Change-Id: I2ae2188611a8018fc8d81ad0b3c3e1e58d6a48c3
Arista-Jenkins
pushed a commit
to aristanetworks/sonic
that referenced
this pull request
Aug 24, 2023
As per discussions with Microsoft and sonic-buildimage PR8583 (sonic-net/sonic-buildimage#8583), we are renaming the midplane interface from eth0.$VLAN_ID to eth1-midplane. Change-Id: I2ae2188611a8018fc8d81ad0b3c3e1e58d6a48c3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to create an
eth1interface in multi-asic namespaces on a linecard so that containers can connect to CHASSIS_APP_DBWhy I did it
Multi-asic instances running on a linecard can't connect to CHASSIS_APP_DB (running on the supervisor) because they are bridged using default docker bridge and can only access local linecard resources.
How I did it
chassisdb.confon a linecard will definemidplane_subnetwhich is the subnet used for the internal networkmidplane_subnetis chosen by the vendor. The only restriction is that should be a /16 subnet.chassisdb_addressinchassisdb.confshould be part ofmidplane_subnet.sonic-platform-modules-*is to create aneth1-midplaneinterface on the linecard that can connect to the supervisor. The IP assigned toeth1-midplaneshould be part ofmidplane_subnetand in the formX.Y.<slot id>.1interfaces-config.shwill create for each namespace of a multi-asic linecard (defined asNUM_ASIC > 1andmidplane_subnetpresent) an ipvlaneth1interface that is attached toeth1-midplane. This interface is assigned an IP in the range defined bymidplane_subnet(i.e.X.Y.<slot id>.(10 + namespace id))To allow using a
midplane_subnetin the127.X.Y.Z/16range, we change the loopback address of the namespacelointerface to127.0.0.1/16(default is/8). This step is already done on the host as per PR5353.When
midplane_subnetis in the127.X.Y.Z/16range, we enable routing on local network so that127/16can be used.How to verify it
Loopback address of a namespace changed to 127.0.0.1/16:
New
eth1interface of asic0 namespace on a linecard in slot 6:New
eth1interface of asic1 namespace on a linecard in slot 6:Check connectivity from namespace asic0 to CHASSIS_APP_DB:
Additional outputs from
ip routeandarpcommands:ip routeoutput from the linecard:ip routeoutput from namespace asic0:ip routeoutput from namespace asic1:arp entries learned on linecard:
arp entries learned on supervisor (arp entries of docker containers removed for clarity):
Which release branch to backport (provide reason below if selected)
Description for the changelog
Configure midplane interface in multi-asic namespaces on a chassis