BRCM Disable ACL Drop counted towards interface RX_DRP counters#8382
Merged
gechiang merged 3 commits intosonic-net:masterfrom Aug 11, 2021
gechiang:master
Merged
BRCM Disable ACL Drop counted towards interface RX_DRP counters#8382gechiang merged 3 commits intosonic-net:masterfrom gechiang:master
gechiang merged 3 commits intosonic-net:masterfrom
gechiang:master
Conversation
4 tasks
judyjoseph
pushed a commit
that referenced
this pull request
Aug 25, 2021
* BRCM Disable ACL Drop counted towards interface RX_DRP counters
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
For all BRCM ACL Drops there is a way not to count these packet drops towards the interface RX_DRP counters by enabling a new SOC property. This SOC property is being enabled on the chosens BRCM HW SKUs config.bcm files.
How to verify it
Send packet that is expected to be drop and check that it is not being counted towards interface RX_DRP counter.
Also tested on S6100, 7260, and TD3 WARM Reboot scenario where this SOC property was not present before the WARM Reboot but become enabled after WARM Reboot.
Which release branch to backport (provide reason below if selected)
Although this change is needed also for the 202012 branch, but the change is not straightforward to cherry pick into that branch so a separate PR will be raised for 202012 branch,
Description for the changelog
Add SOC property to not count ACL Drops towards interface RX_DRP for All BRCM HW SKUs.
A picture of a cute animal (not mandatory but encouraged)