[AS9726-32D] support show system-health by seanwu-ec · Pull Request #8346 · sonic-net/sonic-buildimage

seanwu-ec · 2021-08-05T09:13:14Z

Why I did it

support show system-health on AS9726-32D model.

How I did it

Give a SystemHealth config json, ensure all required systemLED APIs are implemented, Fan, PSU info can be fetched correctly.

How to verify it

Make sure all Hardware checks are passed.
Note : PSU1 wasn't powered on DUT.

root@as9726-32d-2:/home/admin# show system-health detail
System status summary

  System status LED  ControlledByFPGA
  Services:
    Status: OK
  Hardware:
    Status: OK

System services and devices monitor list

Name                        Status    Type
--------------------------  --------  ----------
as9726-32d-2                OK        System
rsyslog                     OK        Process
root-overlay                OK        Filesystem
var-log                     OK        Filesystem
routeCheck                  OK        Program
diskCheck                   OK        Program
container_memory_telemetry  OK        Program
FAN-1F                      OK        Fan
FAN-1R                      OK        Fan
FAN-2F                      OK        Fan
FAN-2R                      OK        Fan
FAN-3F                      OK        Fan
FAN-3R                      OK        Fan
FAN-4F                      OK        Fan
FAN-4R                      OK        Fan
FAN-5F                      OK        Fan
FAN-5R                      OK        Fan
FAN-6F                      OK        Fan
FAN-6R                      OK        Fan
PSU-1 FAN-1                 OK        Fan
PSU-2 FAN-1                 OK        Fan
PSU 2                       OK        PSU

System services and devices ignore list

Name               Status    Type
-----------------  --------  -------
container_checker  Ignored   Service
psu.temperature    Ignored   Device
PSU 1              Ignored   Device
asic               Ignored   Device

Which release branch to backport (provide reason below if selected)

Description for the changelog

[Accton] support show system-health on AS9726-32D

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

- Make it compatible with python3, change python2 print Signed-off-by: Sean Wu <sean_wu@edge-core.com>

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

lgtm-com · 2021-08-05T09:34:07Z

This pull request introduces 1 alert when merging 2ec7542 into 1bc3fdb - view on LGTM.com

new alerts:

1 for Unused import

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

lgtm-com · 2021-08-06T10:15:03Z

This pull request introduces 1 alert when merging cf4aac3 into 302f889 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

seanwu-ec · 2021-08-09T00:52:53Z

This pull request introduces 1 alert when merging cf4aac3 into 302f889 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

I don't know how come LGTM got this alert. namedtuple DOES have 'defaults' argument, and it works well.

https://docs.python.org/3.7/library/collections.html#collections.namedtuple
https://github.com/python/cpython/blob/041bfafeb00b0e5e565986b01c00bf9cddce3b4c/Lib/collections/__init__.py#L316

seanwu-ec · 2021-09-22T07:31:40Z

Hi @lguohan, when you have a moment, would you tell me what changes I need to make in order to get this PR reviewed and merged? I appreciate it.

seanwu-ec · 2021-09-29T06:20:07Z

/azpw run

mssonicbld · 2021-09-29T06:20:09Z

/AzurePipelines run

azure-pipelines · 2021-09-29T06:20:30Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

lgtm-com · 2021-10-21T05:34:34Z

This pull request introduces 1 alert when merging d80c699 into cd0d407 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

* Support lpmode control by CPLD. * PSU status add led status. Signed-off-by: Sean Wu <sean_wu@edge-core.com>

lgtm-com · 2021-11-03T04:05:37Z

This pull request introduces 2 alerts when merging fa571f6 into 689c101 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call
1 for Unused import

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

lgtm-com · 2021-12-10T09:12:42Z

This pull request introduces 1 alert when merging b635441 into 327ad41 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

seanwu-ec · 2021-12-28T05:58:36Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-12-28T05:58:37Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-28T05:58:49Z

Azure Pipelines successfully started running 1 pipeline(s).

* revert commit: 0d63cd7 * revert commit: 0c7b91d * Accton has decided to keep 6-levels thermal threshold APIs only to Accton's customized SONiC instead of polluting Community SONiC code. Signed-off-by: Sean Wu <sean_wu@edge-core.com>

seanwu-ec · 2022-01-24T07:30:46Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2022-01-24T07:30:47Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2022-01-24T07:30:59Z

Azure Pipelines successfully started running 1 pipeline(s).

sujinmkang · 2022-01-31T06:36:15Z

device/accton/x86_64-accton_as9726_32d-r0/pmon_daemon_control.json

 {
    "skip_ledd": true,
-    "skip_thermalctld": true
+    "skip_pcied": true


Is there any specific reason to skip the pcied?

There is no pcie devices, so we skip.

1. Fix wrong get_status_led() 2. Fix wrong get_status() when psu power good failed 3. Fix wrong get_presence() when psu is not presence

seanwu-ec · 2023-05-30T02:31:22Z

sync code to the new PR#14237 due to the code conflict.
so close this.

seanwu-ec added 5 commits August 5, 2021 08:25

Add sensors.conf for AS9726-32D

f2c305e

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

[AS9726-32D] enable thermalctld, disable pcied

3d0addc

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

[AS9726-32D] remove unneeded code in util.py

140b328

- Make it compatible with python3, change python2 print Signed-off-by: Sean Wu <sean_wu@edge-core.com>

[AS9726-32D] add MFR_MAX_TEMP_1 reading in driver

a3a9242

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

[AS9726-32D] support system-health check

2ec7542

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

seanwu-ec added 3 commits August 5, 2021 09:36

Fix LGTM alerts

0be970d

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

[as9726-32d] add thermal thresholds defined by HW

0c7b91d

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

[as9726-32d] skip psu.temperature health check

cf4aac3

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

seanwu-ec marked this pull request as ready for review August 6, 2021 09:57

seanwu-ec requested a review from lguohan as a code owner August 6, 2021 09:57

Fix Sfp.get_name() on AS9726-32D

d80c699

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

Changes for R0C HW

fa571f6

* Support lpmode control by CPLD. * PSU status add led status. Signed-off-by: Sean Wu <sean_wu@edge-core.com>

seanwu-ec and others added 3 commits November 3, 2021 05:41

Fix LGTM alerts, remove unused import

ccfc52c

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

[AS9726-32D] Add CPU coretemp to thermal.py

0d63cd7

Signed-off-by: Sean Wu <sean_wu@edge-core.com>

Merge branch 'master' into as9726-32x_support_systemhealth

b635441

seanwu-ec mentioned this pull request Dec 28, 2021

Test PR, no need to review, thx #9652

Draft

5 tasks

[AS9726-32D] Remove 6-levels temp thresholds

08a8a22

* revert commit: 0d63cd7 * revert commit: 0c7b91d * Accton has decided to keep 6-levels thermal threshold APIs only to Accton's customized SONiC instead of polluting Community SONiC code. Signed-off-by: Sean Wu <sean_wu@edge-core.com>

seanwu-ec requested review from prgeor, sujinmkang and vdahiya12 as code owners January 20, 2022 09:29

Merge branch 'master' into as9726-32x_support_systemhealth

79b3c4d

sujinmkang reviewed Jan 31, 2022

View reviewed changes

seanwu-ec requested a review from a team as a code owner June 10, 2022 02:01

ec-michael-shih added 2 commits June 15, 2022 16:52

[AS9726-32D] Update pcie.yaml

c3b8239

[Edgecore][as9726_32d] Fix wrong "show platform fan" status

425e645

1. Fix wrong get_status_led() 2. Fix wrong get_status() when psu power good failed 3. Fix wrong get_presence() when psu is not presence

seanwu-ec closed this May 30, 2023

Conversation

seanwu-ec commented Aug 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

lgtm-com bot commented Aug 5, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

seanwu-ec commented Aug 9, 2021

Uh oh!

seanwu-ec commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanwu-ec commented Sep 29, 2021

Uh oh!

mssonicbld commented Sep 29, 2021

Uh oh!

azure-pipelines bot commented Sep 29, 2021

Uh oh!

lgtm-com bot commented Oct 21, 2021

Uh oh!

lgtm-com bot commented Nov 3, 2021

Uh oh!

lgtm-com bot commented Dec 10, 2021

Uh oh!

seanwu-ec commented Dec 28, 2021

Uh oh!

mssonicbld commented Dec 28, 2021

Uh oh!

azure-pipelines bot commented Dec 28, 2021

Uh oh!

seanwu-ec commented Jan 24, 2022

Uh oh!

mssonicbld commented Jan 24, 2022

Uh oh!

azure-pipelines bot commented Jan 24, 2022

Uh oh!

sujinmkang Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

akenliu Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

seanwu-ec commented May 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

seanwu-ec commented Aug 5, 2021 •

edited

Loading

seanwu-ec commented Sep 22, 2021 •

edited

Loading