[Mellanox][Pcie] Fix issue on pcied with an id that contains only decimal digits was treated as a decimal number#8309
Merged
lguohan merged 1 commit intosonic-net:masterfrom Aug 3, 2021
Conversation
…imal digits was treated as a decimal number
Contributor
|
@sujinmkang can you please review this PR. |
sujinmkang
approved these changes
Aug 3, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 5, 2021
…imal digits was treated as a decimal number (#8309) A device that contains only decimal digits was mistreated as a decimal integer resulting in failure to find it in the id to bus map.
judyjoseph
pushed a commit
that referenced
this pull request
Aug 7, 2021
…imal digits was treated as a decimal number (#8309) A device that contains only decimal digits was mistreated as a decimal integer resulting in failure to find it in the id to bus map.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…imal digits was treated as a decimal number (sonic-net#8309) A device that contains only decimal digits was mistreated as a decimal integer resulting in failure to find it in the id to bus map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
A device that contains only decimal digits was mistreated as a decimal integer resulting in failure to find it in the id to bus map.
How I did it
Made sure id from the yaml file was treated as a string
How to verify it
Open log on 4600, make sure no error appear.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)