[Arista] Fix Clearwater2 phy initialization when no configuration is provided#8271
Merged
arlakshm merged 2 commits intosonic-net:masterfrom Sep 9, 2021
Merged
[Arista] Fix Clearwater2 phy initialization when no configuration is provided#8271arlakshm merged 2 commits intosonic-net:masterfrom
arlakshm merged 2 commits intosonic-net:masterfrom
Conversation
The config-setup service will fail to initialize the database if the default_sku file is missing. It will try to run `sonic-cfggen` with an empty parameter to the `-k` option. Adding this default_sku will prevent further issues.
Staphylo
force-pushed
the
master-phy-credo-2
branch
from
497d2d0 to
5a68a81
Compare
Collaborator
Author
Contributor
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Aug 20, 2021
Contributor
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
pushed a commit
that referenced
this pull request
Sep 14, 2021
…provided (#8271) Why I did it Fix an issue on the Clearwater2 linecard. When the linecard is started with a fresh image without configuration, phys would not be initialized. How I did it Added default_sku for Clearwater2 which prevents config-setup from failing to create a default config_db.json. Added some extra logic in the phy-credo-init script to run the phy_config.sh of the hwsku pointed by default_sku if the DEVICE_METADATA.localhost.hwsku information is not populated in CONFIG_DB. How to verify it Booting an image with this change and without configuration will lead to the phys being initialized using the phy_config.sh from default_sku.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix an issue on the Clearwater2 linecard.
When the linecard is started with a fresh image without configuration, phys would not be initialized.
How I did it
Added
default_skufor Clearwater2 which preventsconfig-setupfrom failing to create a defaultconfig_db.json.Added some extra logic in the phy-credo-init script to run the
phy_config.shof the hwsku pointed bydefault_skuif theDEVICE_METADATA.localhost.hwskuinformation is not populated inCONFIG_DB.How to verify it
Booting an image with this change and without configuration will lead to the phys being initialized using the
phy_config.shfromdefault_sku.Which release branch to backport (provide reason below if selected)
Cherry-pick required for the 202106 chassis branch.
Description for the changelog
Fix phy initialization on Clearwater2 when booting without configuration