[vs][multi-asic]: Add support to build multi-asic vs images#8270
Merged
SuvarnaMeenakshi merged 5 commits intosonic-net:masterfrom Sep 2, 2021
Merged
[vs][multi-asic]: Add support to build multi-asic vs images#8270SuvarnaMeenakshi merged 5 commits intosonic-net:masterfrom
SuvarnaMeenakshi merged 5 commits intosonic-net:masterfrom
Conversation
- Add a new build parameter BUILD_MKVM to select if multi-asic KVM images should be generated. - Add changes to build 4-asic and 6-asic KVM images if BUILD_MKVM parameter is set to "y". Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
SuvarnaMeenakshi
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
4 tasks
judyjoseph
reviewed
Aug 2, 2021
abdosi
reviewed
Aug 4, 2021
build_image.sh
Outdated
| generate_kvm_image() | ||
| { | ||
| NUM_ASIC=$1 | ||
| if [ $NUM_ASIC == 1 ]; then |
Contributor
Author
There was a problem hiding this comment.
Updated as per comment.
abdosi
reviewed
Aug 4, 2021
build_image.sh
Outdated
| echo "Error : build kvm image failed" | ||
| exit 1 | ||
| # Generate single asic KVM image | ||
| generate_kvm_image 1 |
Contributor
Author
There was a problem hiding this comment.
Updated as per comment.
abdosi
reviewed
Aug 4, 2021
abdosi
reviewed
Aug 4, 2021
Modify build parameter to BUILD_MULTIASIC_KVM. Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
judyjoseph
previously approved these changes
Aug 17, 2021
lguohan
reviewed
Aug 27, 2021
lguohan
reviewed
Aug 27, 2021
lguohan
previously approved these changes
Aug 27, 2021
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
SuvarnaMeenakshi
dismissed stale reviews from lguohan and judyjoseph
via
5dabc90
judyjoseph
approved these changes
Sep 1, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Pre-requisite: #8269
How I did it
How to verify it
Generate single-asic VS as currently done, no change in build steps:
make configure PLATFORM=vs
make target/sonic-vs.img.gz - will generate only single asic KVM image.
make BUILD_MULTIASIC_KVM=y target/sonic-vs.img.gz - will generate single asic and multi-asic KVM images.
should generate:
sonic-vs.bin
sonic-vs.img.gz
sonic-4asic-vs.img.gz
sonic-6asic-vs.img.gz
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)