[multi-asic] Fix for sonic-cfggen exception during platform string read

[minionatwork]

during fresh install and start of sonic in multi asic, /var/run/redisX/ is created after database docker is
started. Currently sonic-cfggen is throwing exception while reading platform string from /usr/bin/database.sh

sonic python3[2259]: :- parseDatabaseConfig: Sonic database config file doesn't exist at /var/run/redis/sonic-db/../../redis0/sonic-db/database_config.json
sonic python3[2259]: :- initializeGlobalConfig: Sonic database config file syntax error >> Sonic database config file doesn't exist at /var/run/redis/sonic-db/../../redis0/sonic-db/database_config.json
sonic database.sh[2259]: Traceback (most recent call last):
sonic database.sh[2259]: File "/usr/local/bin/sonic-cfggen", line 452, in
sonic database.sh[2259]: main()
sonic database.sh[2259]: File "/usr/local/bin/sonic-cfggen", line 310, in main
sonic database.sh[2259]: SonicDBConfig.load_sonic_global_db_config(namespace=args.namespace)
sonic database.sh[2259]: File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1342, in load_sonic_global_db_config
sonic database.sh[2259]: SonicDBConfig.initializeGlobalConfig(global_db_file_path)
sonic database.sh[2259]: RuntimeError: Sonic database config file syntax error >> Sonic database config file doesn't exist at /var/run/redis/sonic-db/../../redis0/sonic-db/database_config.json
sonic database.sh[2246]: Creating new database0 container
sonic database.sh[2516]: 4be09b19659f7db6f8399455f32b9f7c7a47ee66f67c4d0dddf1c54fb0f9d59c
sonic database.sh[3296]: database0

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

[arlakshm]

@minionatwork. We are not hitting this issue when we bring-up a multi asic VS. Is there specific sequence of steps done to repro this issue ?

adding @SuvarnaMeenakshi for viz.

[minionatwork]

It was straightforward happening after first install and boot of sonic.

This file is created inside docker (database docker) but to start database docker, this file is was checked and exception happens. So, I dont know how multi asic VS is working. Discussed with Judy offline. He might have more picture on this how multi asic VS is working.

/var/run/redis/sonic-db/../../redis0/sonic-db/database_config.json

[judyjoseph]

@minionatwork. We are not hitting this issue when we bring-up a multi asic VS. Is there specific sequence of steps done to repro this issue ?

adding @SuvarnaMeenakshi for viz.

Thanks to @suvarna for the multi-vs image, did a check on this error, so I see it happens there too on the first boot directly as a multi-asic VS ( earlier we didn't observe as we were booting in single ASIC mode and then converting to multi-asic VS).

This is happening as we started to use swsscommon dbconnector classes and there the checks are strict and we throw runtime_error. Ref: https://github.com/Azure/sonic-swss-common/blob/f89b2ac1049c61f77b14fefc2fb0f252e1bd7aa7/common/dbconnector.cpp#L66

We will take in this fix --as this will make sure that in sonic-cfggen we load_global_config only when we pass a namespace parameter.

[judyjoseph]

looks ok in multi-asic device too where global database config json is used.

[anamehra]

Hi Judy (@judyjoseph ), I am seeing this issue on a multi asic system.
This is happening for database container itself:
Jul 21 19:42:56 sonic database.sh[58861]: + DOCKERMOUNT=
Jul 21 19:42:56 sonic database.sh[58861]: + '[' x == x ']'
Jul 21 19:42:56 sonic database.sh[58861]: + preStartAction
Jul 21 19:42:56 sonic database.sh[58861]: + WARM_DIR=/host/warmboot
Jul 21 19:42:56 sonic database.sh[58861]: + '[' '' '!=' chassisdb ']'
Jul 21 19:42:56 sonic database.sh[58861]: + [[ cold == \w\a\r\m ]]
Jul 21 19:42:56 sonic database.sh[58861]: + [[ cold == \f\a\s\t\f\a\s\t ]]
Jul 21 19:42:56 sonic database.sh[58861]: + echo -n
Jul 21 19:42:56 sonic database.sh[58861]: + docker cp /tmp/dump.rdb database:/var/lib/redis/
Jul 21 19:42:57 sonic database.sh[58861]: + updateSyslogConf
Jul 21 19:42:57 sonic database.sh[58861]: + [[ 2 -gt 1 ]]
Jul 21 19:42:57 sonic database.sh[58905]: ++ docker network inspect bridge '--format={{(index .IPAM.Config 0).Gateway}}'
Jul 21 19:42:57 sonic database.sh[58861]: + TARGET_IP=240.127.1.1
Jul 21 19:42:57 sonic database.sh[58861]: + CONTAINER_NAME=database
Jul 21 19:42:57 sonic database.sh[58861]: + TMP_FILE=/tmp/rsyslog.database.conf
Jul 21 19:42:57 sonic database.sh[58861]: + sonic-cfggen -t /usr/share/sonic/templates/rsyslog-container.conf.j2 -a '{"target_ip": "240.127.1.1", "container_name": "database" }'
Jul 21 19:42:57 sonic python3[58918]: :- parseDatabaseConfig: Sonic database config file doesn't exist at /var/run/redis/sonic-db/database_config.json
Jul 21 19:42:57 sonic database.sh[58918]: Traceback (most recent call last):
Jul 21 19:42:57 sonic database.sh[58918]: File "/usr/local/bin/sonic-cfggen", line 441, in
Jul 21 19:42:57 sonic database.sh[58918]: main()
Jul 21 19:42:57 sonic database.sh[58918]: File "/usr/local/bin/sonic-cfggen", line 402, in main
Jul 21 19:42:57 sonic database.sh[58918]: env = _get_jinja2_env(paths)
Jul 21 19:42:57 sonic database.sh[58918]: File "/usr/local/bin/sonic-cfggen", line 237, in _get_jinja2_env
Jul 21 19:42:57 sonic database.sh[58918]: redis_bcc = RedisBytecodeCache(SonicV2Connector(host='127.0.0.1'))
Jul 21 19:42:57 sonic database.sh[58918]: File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1704, in init
Jul 21 19:42:57 sonic database.sh[58918]: for db_name in self.get_db_list():
Jul 21 19:42:57 sonic database.sh[58918]: File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1640, in get_db_list
Jul 21 19:42:57 sonic database.sh[58918]: return _swsscommon.SonicV2Connector_Native_get_db_list(self)
Jul 21 19:42:57 sonic database.sh[58918]: RuntimeError: Sonic database config file doesn't exist at /var/run/redis/sonic-db/database_config.json
Jul 21 19:42:57 sonic database.sh[58861]: + docker cp /tmp/rsyslog.database.conf database:/etc/rsyslog.conf
Jul 21 19:42:58 sonic database.sh[58861]: + rm -rf /tmp/rsyslog.database.conf
Jul 21 19:42:58 sonic database.sh[58861]: + echo 'Starting existing database container'
Jul 21 19:42:58 sonic database.sh[58861]: Starting existing database container

My worspace is based of following commit id:
commit 63ba489
Date: Wed Sep 8 19:59:50 2021 +0300

[qiluo-msft]

SonicDBConfig.load_sonic_global_db_config(namespace=args.namespace)

An extreme case:
if both args.from_db and args.write_to_db have valid stirng, will the second load_sonic_global_db_config throw exception?