[build]: Allow build-time specification of alternative docker registries#8134
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jul 14, 2021
Merged
Conversation
qiluo-msft
approved these changes
Jul 9, 2021
lguohan
changed the title
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 15, 2021
…ies (#8134) Why I did it Allows users to host their own local docker registries and utilize them via the REGISTRY_SERVER and REGISTRY_PORT environmental variables How I did it Only set REGISTRY_SERVER and REGISTRY_PORT in rules/config if they are unset. How to verify it Export environmental variables REGISTRY_SERVER and REGISTRY_PORT to an alternative docker registry. Export the environmental variable ENABLE_DOCKER_BASE_PULL to y. Ensure the required sonic-slave docker images are not present locally, but are available in the docker registry Execute make init and make configure Confirm that the appropriate docker images were pulled from the appropriate docker registry, and not built locally
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
…ies (#8134) Why I did it Allows users to host their own local docker registries and utilize them via the REGISTRY_SERVER and REGISTRY_PORT environmental variables How I did it Only set REGISTRY_SERVER and REGISTRY_PORT in rules/config if they are unset. How to verify it Export environmental variables REGISTRY_SERVER and REGISTRY_PORT to an alternative docker registry. Export the environmental variable ENABLE_DOCKER_BASE_PULL to y. Ensure the required sonic-slave docker images are not present locally, but are available in the docker registry Execute make init and make configure Confirm that the appropriate docker images were pulled from the appropriate docker registry, and not built locally
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…ies (sonic-net#8134) Why I did it Allows users to host their own local docker registries and utilize them via the REGISTRY_SERVER and REGISTRY_PORT environmental variables How I did it Only set REGISTRY_SERVER and REGISTRY_PORT in rules/config if they are unset. How to verify it Export environmental variables REGISTRY_SERVER and REGISTRY_PORT to an alternative docker registry. Export the environmental variable ENABLE_DOCKER_BASE_PULL to y. Ensure the required sonic-slave docker images are not present locally, but are available in the docker registry Execute make init and make configure Confirm that the appropriate docker images were pulled from the appropriate docker registry, and not built locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Allows users to host their own local docker registries and utilize them via the
REGISTRY_SERVERandREGISTRY_PORTenvironmental variablesHow I did it
Only set
REGISTRY_SERVERandREGISTRY_PORTinrules/configif they are unset.How to verify it
REGISTRY_SERVERandREGISTRY_PORTto an alternative docker registry. Export the environmental variableENABLE_DOCKER_BASE_PULLtoy.sonic-slavedocker images are not present locally, but are available in the docker registrymake initandmake configureWhich release branch to backport (provide reason below if selected)
Description for the changelog
Allow build-time specification of alternative docker registries
A picture of a cute animal (not mandatory but encouraged)