Reproducible build support docker image#8039
Merged
liushilongbuaa merged 4 commits intosonic-net:masterfrom Jul 9, 2021
Merged
Reproducible build support docker image#8039liushilongbuaa merged 4 commits intosonic-net:masterfrom
liushilongbuaa merged 4 commits intosonic-net:masterfrom
Conversation
xumia
reviewed
Jul 2, 2021
xumia
reviewed
Jul 2, 2021
xumia
reviewed
Jul 2, 2021
xumia
reviewed
Jul 2, 2021
xumia
reviewed
Jul 2, 2021
f0d0169 to
3d94cf2
Compare
xumia
reviewed
Jul 2, 2021
05994db to
6ed6922
Compare
Collaborator
|
Could you add the link of the design doc in the PR description? |
qiluo-msft
reviewed
Jul 6, 2021
qiluo-msft
reviewed
Jul 6, 2021
qiluo-msft
reviewed
Jul 6, 2021
qiluo-msft
approved these changes
Jul 7, 2021
Collaborator
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please also check with other reviewers.
Contributor
Author
|
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 13, 2021
when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.
judyjoseph
pushed a commit
that referenced
this pull request
Jul 13, 2021
when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)