Skip to content

Reproducible build support docker image#8039

Merged
liushilongbuaa merged 4 commits intosonic-net:masterfrom
liushilongbuaa:reproducible-docker
Jul 9, 2021
Merged

Reproducible build support docker image#8039
liushilongbuaa merged 4 commits intosonic-net:masterfrom
liushilongbuaa:reproducible-docker

Conversation

@liushilongbuaa
Copy link
Copy Markdown
Contributor

@liushilongbuaa liushilongbuaa commented Jul 2, 2021

Why I did it

when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@liushilongbuaa liushilongbuaa force-pushed the reproducible-docker branch 2 times, most recently from f0d0169 to 3d94cf2 Compare July 2, 2021 09:52
@liushilongbuaa liushilongbuaa marked this pull request as ready for review July 6, 2021 07:23
@qiluo-msft
Copy link
Copy Markdown
Collaborator

Could you add the link of the design doc in the PR description?

Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also check with other reviewers.

@liushilongbuaa
Copy link
Copy Markdown
Contributor Author

Could you add the link of the design doc in the PR description?

https://github.com/xumia/SONiC/blob/repd3/doc/sonic-build-system/SONiC-Reproduceable-Build.md

@liushilongbuaa liushilongbuaa merged commit 4b3b4c0 into sonic-net:master Jul 9, 2021
qiluo-msft pushed a commit that referenced this pull request Jul 13, 2021
when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.
judyjoseph pushed a commit that referenced this pull request Jul 13, 2021
when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
when build docker image, we need a base image. now base image is specified by tag. we can use sha256 to specify docker image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants