Skip to content

[AS4630-54PE] Modify util.py to python3 and remove code#8033

Merged
lguohan merged 2 commits intosonic-net:masterfrom
jostar-yang:as4630-54pe_20210701_remove_extra_util
Jul 14, 2021
Merged

[AS4630-54PE] Modify util.py to python3 and remove code#8033
lguohan merged 2 commits intosonic-net:masterfrom
jostar-yang:as4630-54pe_20210701_remove_extra_util

Conversation

@jostar-yang
Copy link
Copy Markdown
Contributor

@jostar-yang jostar-yang commented Jul 1, 2021

Signed-off-by: Jostar Yang [email protected]

Why I did it

Modify accton_as4630_54pe_util.py to support Python3 and remove not need code.

How I did it

Modify accton_as4630_54pe_util.py to support Python3 and remove not need code.

How to verify it

Test,
./accton_as4630_54pe_util.py install and can setup device well
/accton_as4630_54pe_util.py install and can remove device well

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@jostar-yang jostar-yang requested a review from lguohan as a code owner July 1, 2021 08:46
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 1, 2021

This pull request introduces 1 alert when merging 5ce4639 into 1da8c14 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lguohan lguohan merged commit 2d83004 into sonic-net:master Jul 14, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Modify accton_as4630_54pe_util.py to support Python3 and remove not need code.

Signed-off-by: Jostar Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants