Feature yang changes

[arlakshm]

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com

Why I did it

Add yang model for Feature configuration

How I did it

Add feature.yang and unit tests

How to verify it

Compile target/python-wheels/sonic_yang_models-1.0-py3-none-any.whl

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• [x ] 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

[zhangyanzhao]

not ready for review, need move it back to "To be Reviewed column"

[zhangyanzhao]

Arvind will handle the comments from Venkat.

[venkatmahalingam]

@arlakshm In the mgmt VRF YANG, boolean value is represented as "true" in the below file, please try this for your case as well.
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/tests/files/sample_config_db.json#L281

[zhangyanzhao]

@arlakshm please address the comments from Venkat. Thanks.

[arlakshm]

@arlakshm In the mgmt VRF YANG, boolean value is represented as "true" in the below file, please try this for your case as well.
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/tests/files/sample_config_db.json#L281

The backend python code expects "True" or "False" I think change to "true" may not work.

[venkatmahalingam]

@arlakshm In the mgmt VRF YANG, boolean value is represented as "true" in the below file, please try this for your case as well.
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/tests/files/sample_config_db.json#L281

The backend python code expects "True" or "False" I think change to "true" may not work.

boolean type is represented as "true/"false" in the table (MGMT VRF, LLDP..etc) fields, can we change the backend to accept "true"/"false" to be consistent.

[abdosi]

@arlakshm does always_enabled applies for high_mem_alert ?

[yozhao101]

@arlakshm does always_enabled applies for high_mem_alert ?

I think it is OK to let high_mem_alert support the option always_enabled.