[sonic-host-services] Add 'parameterized' package as a test dependency#7900
Merged
jleveque merged 1 commit intosonic-net:masterfrom Jun 17, 2021
jleveque:fix_deps
Merged
[sonic-host-services] Add 'parameterized' package as a test dependency#7900jleveque merged 1 commit intosonic-net:masterfrom jleveque:fix_deps
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:fix_deps
Conversation
prsunny
approved these changes
Jun 16, 2021
Contributor
|
thanks @jleveque |
tahmed-dev
approved these changes
Jun 16, 2021
Contributor
Contributor
Author
4 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 17, 2021
#7900) #### Why I did it Recently, the build started failing with messages like ``` 2021-06-16T16:55:02.8675603Z tests/hostcfgd/hostcfgd_test.py:5: in <module> 2021-06-16T16:55:02.8676208Z from parameterized import parameterized 2021-06-16T16:55:02.8677145Z E ModuleNotFoundError: No module named 'parameterized' ``` Unit tests for hostcfgd depend on the `parameterized` Python package, but it was never added as a dependency to the setup.py file. This dependency was added ~3 months ago. I'm not sure why we only started seeing this failure recently. #### How I did it Add 'parameterized' package as a test dependency in setup.py for sonic-host-services package
4 tasks
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
sonic-net#7900) #### Why I did it Recently, the build started failing with messages like ``` 2021-06-16T16:55:02.8675603Z tests/hostcfgd/hostcfgd_test.py:5: in <module> 2021-06-16T16:55:02.8676208Z from parameterized import parameterized 2021-06-16T16:55:02.8677145Z E ModuleNotFoundError: No module named 'parameterized' ``` Unit tests for hostcfgd depend on the `parameterized` Python package, but it was never added as a dependency to the setup.py file. This dependency was added ~3 months ago. I'm not sure why we only started seeing this failure recently. #### How I did it Add 'parameterized' package as a test dependency in setup.py for sonic-host-services package
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Recently, the build started failing with messages like
Unit tests for hostcfgd depend on the
parameterizedPython package, but it was never added as a dependency to the setup.py file. This dependency was added ~3 months ago. I'm not sure why we only started seeing this failure recently.How I did it
Add 'parameterized' package as a test dependency in setup.py for sonic-host-services package
How to verify it
Which release branch to backport (provide reason below if selected)