Adding mmu buffer yang files#7838
Conversation
|
Iguohan/Neethajohn Could you review the PR and share you feedback |
praveen-li
left a comment
praveen-li
left a comment
There was a problem hiding this comment.
Updated comments from YANG WG.
| type string; | ||
| } | ||
|
|
||
| leaf static_th { |
There was a problem hiding this comment.
We can have either static or dynamic, we may need choice statement here
There was a problem hiding this comment.
Yes, will add a choice statement here.
There was a problem hiding this comment.
Praveen I tried following choice/case statement for the threshold, but got the error mentioned below.
Statement-
choice threshold_type {
mandatory true;
case static {
leaf static_th {
type uint64;
description "The maximum size of the buffer pool the port can occupy";
}
}
case dynamic {
leaf dynamic_th {
type int32 {
range "-7..3";
}
description "The maximum proportion of the free size of the buffer pool the port can occupy (Alpha value)";
}
}
}
Error-
self.root = None
self.sysLog(msg="Data Loading Failed:{}".format(str(e)), \
debug=syslog.LOG_ERR, doPrint=True)
raise SonicYangException("Data Loading Failed\n{}".format(str(e)))
E sonic_yang_ext.SonicYangException: Data Loading Failed
E string indices must be integers
There was a problem hiding this comment.
Praveen, Do you see any issue with the above yang block for choice.
|
|
||
| leaf profile { //Hash reference key | ||
| type leafref { | ||
| path "/bpf:sonic-buffer-profile/bpf:BUFFER_PROFILE/bpf:BUFFER_PROFILE_LIST/bpf:name"; |
There was a problem hiding this comment.
This PR has a dependency on sonic-net/sonic-swss#1754, please merge this PR once the dependent PR is merged.
There was a problem hiding this comment.
Venkat, sonic-net/sonic-swss#1754 is still not merged. Does the current PR has dependency on #1754.
There was a problem hiding this comment.
Yes, the current backend expectation is to have a table name (BUFFER_PROFILE) also while referencing to profile table from BUFFER_QUEUE and other tables.
127.0.0.1:6379[4]> hgetall BUFFER_QUEUE|Ethernet38|5-6
- "profile"
- "[BUFFER_PROFILE|egress_lossy_profile]"
|
@venkatmahalingam will take a further look, then we can merge. |
This PR has a dependency on sonic-net/sonic-swss#1754 |
src/sonic-yang-models/yang-models/sonic-buffer-port-egress-profile-list.yang
Show resolved
Hide resolved
src/sonic-yang-models/yang-models/sonic-buffer-port-ingress-profile-list.yang
Show resolved
Hide resolved
|
BRCM team will follow-up this. |
|
Please check with @stephenxs on the approval. Thanks. |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 7838 in repo Azure/sonic-buildimage |
|
@neethajohn Can you see if this PR can be merged. Stephen had approved the changes. Builds & tests failure were not related to the changes in this PR. After rebase all builds are successful and tests are passing. |
9 participants
Why I did it
Added Buffer yang files derived from sonic/mgmt-cvl/testdata/schema from sonic-mgmt-common, used by mgmt-framework.
Updated BUFFER_PG|({ifname},)*|{pg_num} to BUFFER_PG|{ifname}|{pg_num} in sonic-buffer-pg.yang.
This change is required for configuration migration for dynamic port breakout operation.
Added sonic-buffer-queue.yang for BUFFER_QUEUE
Tables: BUFFER_POOL, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE.
How I did it
Defined Yang models for BUFFER tables based on Guideline doc:
https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md
and
https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md
How to verify it
sonic_yang_models package build.
Which release branch to backport (provide reason below if selected)
Description for the changelog
MMU Buffer yang files (BUFFER_POOL/BUFFER_PROFILE/BUFFER_PG/BUFFER_QUEUE)