[Mellanox] Add new SKU Mellanox-SN4600C-C64#7815
Conversation
liat-grozovik
changed the title
liat-grozovik
changed the title
| @@ -0,0 +1 @@ | |||
| ../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2 No newline at end of file | |||
There was a problem hiding this comment.
if the SKU is not expected to support dynamic buffer calculation do we still need to have the file?
@stephenxs can you please comment on that?
There was a problem hiding this comment.
@liat-grozovik
In theory, we don't need this file given that the dynamic buffer calculation is disabled in this SKU.
But I suggest keeping it to make it consistent with other SKUs - we have this file in all SKUs regardless of whether dynamic buffer calculation is enabled.
| @@ -0,0 +1 @@ | |||
| ../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers.json.j2 No newline at end of file | |||
There was a problem hiding this comment.
Why do we need to point to 2700? Can we use ACS-MSN4600C instead?
|
It will be a link to a link . The idea was to have it directed to the original file like in any other SKU
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Prince Sunny ***@***.***>
Sent: Monday, June 14, 2021 10:08:17 PM
To: Azure/sonic-buildimage ***@***.***>
Cc: Liat Grozovik ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/sonic-buildimage] [Mellanox] Add new SKU Mellanox-SN4600C-C64 (#7815)
@prsunny commented on this pull request.
________________________________
In device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-C64/buffers.json.j2<#7815 (comment)>:
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers.json.j2
Why do we need to point to 2700? Can we use ACS-MSN4600C instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#7815 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABAYH5PKAZ7GA2SW6QVDTSZHSDANCNFSM46IYPBGQ>.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7815 in repo Azure/sonic-buildimage |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@liat-grozovik 202012 branch does not have hwsku.json file in the SKU folder. So, it can not be cherry picked from master branch to 202012 branch. I will be raising a separate PR. Thanks. |
Add new SKU of SN4600C switch: Mellanox-SN4600c-c64 Co-authored-by: Madhan Babu <[email protected]>
Add new SKU of SN4600C switch: Mellanox-SN4600c-c64 Co-authored-by: Madhan Babu <[email protected]>
|
SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 line will be removed due to new VXLAN src port range implementation #9956 |
6 participants
Why I did it
Add new SKU of SN4600C switch: Mellanox-SN4600c-c64
How I did it
Added all relevant files to support the new SKU requirements:
Port configuration: No breakout required. All ports configured with 100G
Buffer configuration
• Shared headroom enable. over-subscription ratio as in SN3800
• Dynamic Buffer disable
Switch configuration
• Warmboot enabled. Added to SAI profile
• Is VxLAN source port range set as in SN3800
Number of Uplinks/Downlinks:
• t0: 32 100G down links and 32 100G up links.
• t1: 56 100G down links and 8 100G up links.
How to verify it
Set the SKU in config_db.json to Mellanox-SN4600C-C64 and test the 100G ports coming up on the switch.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Changes are in sonic-buildimage/device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-C64/ folder.
A picture of a cute animal (not mandatory but encouraged)