Flashrom refactoring for broadcom platforms#7693
Merged
jleveque merged 3 commits intosonic-net:masterfrom Jun 22, 2021
Merged
Conversation
jleveque
previously approved these changes
May 28, 2021
Contributor
Author
|
On checking the build artifact, flashrom deb package was not included in the broadcom.bin image(Must be an issue with local build which already generated flashrom deb package). |
Contributor
Author
|
Building is blocked because previous build iteration didnt generate target/debs/buster/flashrom_*.deb package. |
santhosh-kt
changed the title
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@qiluo-msft, @xumia: Can you please review, also? |
qiluo-msft
reviewed
Jun 2, 2021
qiluo-msft
approved these changes
Jun 3, 2021
jleveque
approved these changes
Jun 16, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
#### Why I did it - To build flashrom properly with dependency tracking. #### How I did it - Moved flashrom code from platform/broadcom/sonic-platform-modules-dell/tools directory to src/flashrom directory. - At the end, flashrom_0.9.7_amd64.deb package is build which will be installed in the devices. - Currently flashrom builds only for Dell S6100 platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Logs - PR.txt
Which release branch to backport (provide reason below if selected)
Description for the changelog
On branch flashrom-ref
Changes to be committed:
(use "git reset HEAD ..." to unstage)
Please dont approve the changes till the build for all arch gets success.
A picture of a cute animal (not mandatory but encouraged)