[radv] fix bug for radv can't startup if DEVICE_METADATA.localhost.type not exist#7651
Merged
prsunny merged 1 commit intosonic-net:masterfrom May 25, 2021
Merged
Conversation
|
|
prsunny
reviewed
May 19, 2021
| {%- set vlan_v6.count = vlan_v6.count + 1 -%} | ||
| {%- endif -%} | ||
| {%- endfor -%} | ||
| {%- if DEVICE_METADATA.localhost.type -%} |
Contributor
There was a problem hiding this comment.
Why would localhost.type not exists. This field is being used in multiple places in Sonic. IMO, this is a missing config. However, changes lgtm. @jleveque for viz.
Contributor
There was a problem hiding this comment.
Agree. This change will not hurt anything, but I don't understand a situation where DEVICE_METADATA.localhost.type would not exist.
Contributor
Author
There was a problem hiding this comment.
Config default_preset field in default_sku to l2, then the generated config_db.json won't have DEVICE_METADATA.localhost.type field.
sonic-cfggen was upgraded to python3. If DEVICE_METADATA.localhost.type is not exist, rendering docker-router-advertiser.supervisord.conf.j2 will fail.
prsunny
approved these changes
May 19, 2021
jleveque
approved these changes
May 19, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
May 26, 2021
…pe is NULL (#7651) Co-authored-by: Shi Lei <shil@centecnetworks.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…pe is NULL (sonic-net#7651) Co-authored-by: Shi Lei <shil@centecnetworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
docker radv can't startup if DEVICE_METADATA.localhost.type not exist
How I did it
add check for DEVICE_METADATA.localhost.type exist
How to verify it
build the sonic image, run on board, and radv can startup
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)