Support L1 & L3 Config generation in SONiC #7637
Support L1 & L3 Config generation in SONiC #7637judyjoseph merged 9 commits intosonic-net:masterfrom VenkatCisco:VenkatCisco/master/PR12_L1_L2_cfg
Conversation
VenkatCisco
changed the title
VenkatCisco
changed the title
| 'l2': generate_l2_config, | ||
| 'empty': generate_empty_config | ||
| 'empty': generate_empty_config, | ||
| 'l1': generate_l1_config, |
There was a problem hiding this comment.
Can you please add a unit test for this? You can refer as done for #7215
There was a problem hiding this comment.
Thanks for the comments. Added UT. Please review.
There was a problem hiding this comment.
@prsunny do you have any more comments or else would be able to approve this PR ?
|
How is this different from #7368. I see it being actively reviewed? |
We discussed in todays scrum. The PR was raised agains #7368 but a new set of updates to the existing PR ends up been tracked as different PR (i raised this in todays mtg with Anshu/Guhon as well). I confirmed that #7368 will be closed and tracked via #7637 |
| UNICODE_TYPE = unicode | ||
|
|
||
|
|
||
| # The new enhancements to this file provides capabilities to generate l1 & l3 |
There was a problem hiding this comment.
This comment looks more like PR description. I think this should be removed.
There was a problem hiding this comment.
Also, it will require the comment update again once someone add an additional template..
There was a problem hiding this comment.
Thanks. Fixed the comments and uploaded the new change.
There was a problem hiding this comment.
The tests for both L1 & L3 passed as belows.
test_l1_ports_template (tests.test_j2files.TestJ2Files) ... ok
test_l3_ports_template (tests.test_j2files.TestJ2Files) ... ok
New failures are seen in unrleated area.
…Cisco/sonic-buildimage into VenkatCisco/master/PR12_L1_L2_cfg
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thanks for triggering the run. would you able able to approve given all tests have passed now ? |
|
@VenkatCisco, can you remove this file src/sonic-config-engine/.config_samples.py.swp from this PR ? |
| "Ethernet5": {}, | ||
| "Ethernet6": {}, | ||
| "Ethernet7": {}, | ||
| "Ethernet8": {}, |
There was a problem hiding this comment.
Since this is an l3 template did you want to add IP addresses to these interfaces in your usecase?
There was a problem hiding this comment.
@VenkatCisco, can you remove this file src/sonic-config-engine/.config_samples.py.swp from this PR ?
Sure, removed.
There was a problem hiding this comment.
Since this is an l3 template did you want to add IP addresses to these interfaces in your usecase?
In the review mtg, there was an ask from Guhon and team to not hardcode the ip address etc. Even though the config_samples.py has other areas like generate_t1_sample_config catered to specific needs, this method is made more generic as per request.
Done. removed the .swp file. |
|
/azp run |
|
No commit pushedDate could be found for PR 7637 in repo Azure/sonic-buildimage |
|
@abdosi - can you please review, approve asap. |
Why I did it This provides support for: PR #7074. How I did it Extend sonic-config-engine/config_samples.py to provide support for l1 & l3
|
@judyjoseph Please help to add this to 202012 and 2012911 as well. |
Why I did it This provides support for: PR #7074. How I did it Extend sonic-config-engine/config_samples.py to provide support for l1 & l3
Why I did it This provides support for: PR sonic-net#7074. How I did it Extend sonic-config-engine/config_samples.py to provide support for l1 & l3
8 participants
Why I did it
This provides support for: PR #7074.
How I did it
Extend sonic-config-engine/config_samples.py to provide support for l1 & l3
How to verify it
Verify system bring up with L1 & L3 configuration
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)