[sonic-app-ext] support app extensions installation during build by stepanblyschak · Pull Request #7593 · sonic-net/sonic-buildimage

stepanblyschak · 2021-05-12T12:56:03Z

Signed-off-by: Stepan Blyschak stepanb@mellanox.com

Why I did it

To support building DHCP relay as extension and installing it during build time.

How I did it

Created infrastructure. Users need to define their packages in rules/sonic-packages.mk

How to verify it

Together with #6531

Which release branch to backport (provide reason below if selected)

201811
201911
202006
202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

tahmed-dev

LGTM. just a minor comment

tahmed-dev · 2021-05-12T16:30:26Z

files/scripts/swss.sh

 #!/bin/bash

-DEPENDENT="radv dhcp_relay"
+DEPENDENT="radv"


nit: dhcp_relay should be still in the DEPENDENT. It should be remove by the DHCP PR #6531

@stepanblyschak , can you please resolve this nit comment?

It is already resolved, forgot to put a comment about it.

liat-grozovik · 2021-05-13T08:32:19Z

/azp run

azure-pipelines · 2021-05-13T08:32:35Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-05-25T10:15:33Z

/azp run

azure-pipelines · 2021-05-25T10:15:52Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-05-27T09:11:42Z

/azp run

azure-pipelines · 2021-05-27T09:11:59Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-05-30T06:41:27Z

@stepanblyschak please handle conflicts and rerun tests.

…xt-build Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

liat-grozovik · 2021-05-31T13:33:59Z

/azp run

azure-pipelines · 2021-05-31T13:34:16Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-06-07T08:51:44Z

/azp run

azure-pipelines · 2021-06-07T08:52:00Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2021-06-11T16:17:59Z

~~There is some problem with build I doubt it is related to this change~~, VS build fails:

dpkg-checkbuilddeps: error: Unmet build dependencies: python3-pytest
dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting
dpkg-buildpackage: warning: (Use -d flag to override.)
Makefile:11: recipe for target '/sonic/target/debs/stretch/frr_7.5.1-sonic-0_amd64.deb' failed

~~The same frr package has been built succsfully for mellanox and broadcom~~. Also, kvmtests just stuck and do not retrigger.

EDIT: fixed ptf docker build in latest commit.

…ic-utilities for dockers that dont need it Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

liat-grozovik · 2021-06-15T08:49:36Z

/azp run

azure-pipelines · 2021-06-15T08:49:54Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2021-06-15T16:00:35Z

tests/hostcfgd/hostcfgd_test.py:5: in <module>
    from parameterized import parameterized
E   ModuleNotFoundError: No module named 'parameterized'

Same build error observed in different PR - https://dev.azure.com/mssonic/build/_build/results?buildId=19675&view=logs&j=88ce9a53-729c-5fa9-7b6e-3d98f2488e3f&t=8d99be27-49d0-54d0-99b1-cfc0d47f0318

liat-grozovik · 2021-06-18T07:45:22Z

/azp run

azure-pipelines · 2021-06-18T07:45:40Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-06-23T17:54:06Z

@stepanblyschak can you please handle the new conflict?
@tahmed-dev and @renukamanavalan could you please help to review?

files/scripts/swss.sh

liat-grozovik · 2021-06-26T09:41:54Z

@renukamanavalan and @tahmed-dev can you please approve?

renukamanavalan · 2021-06-26T16:30:20Z

@tahmed-dev can you please approve?
I am good with this PR.

…ic-net#7593) Signed-off-by: Stepan Blyschak stepanb@mellanox.com Why I did it To support building DHCP relay as extension and installing it during build time. How I did it Created infrastructure. Users need to define their packages in rules/sonic-packages.mk How to verify it Together with sonic-net#6531

qiluo-msft · 2025-12-05T20:44:23Z

slave.mk

 		$(eval export $(subst -,_,$(notdir $($*.gz_PATH)))_whls=$(shell printf "$(subst $(SPACE),\n,$(call expand,$($*.gz_PYTHON_WHEELS)))\n" | awk '!a[$$0]++'))
 		$(eval export $(subst -,_,$(notdir $($*.gz_PATH)))_dbgs=$(shell printf "$(subst $(SPACE),\n,$(call expand,$($*.gz_DBG_PACKAGES)))\n" | awk '!a[$$0]++'))
 		$(eval export $(subst -,_,$(notdir $($*.gz_PATH)))_pkgs=$(shell printf "$(subst $(SPACE),\n,$(call expand,$($*.gz_APT_PACKAGES)))\n" | awk '!a[$$0]++'))
+		if [ -d $($*.gz_PATH)/cli-plugin-tests/ ]; then pushd $($*.gz_PATH)/cli-plugin-tests; pytest-$($(SONIC_UTILITIES_PY3)_PYTHON_VERSION) -v $(LOG); popd; fi


pytest

Could you move python unit test out of the process of building a docker image target? We should treat this package as a normal standalone python wheel target.

[sonic-app-ext] support app extensions installation during build

c1f7e32

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

stepanblyschak requested review from lguohan, qiluo-msft and xumia as code owners May 12, 2021 12:56

stepanblyschak mentioned this pull request May 12, 2021

[dhcp-relay] make DHCP relay an extension #6531

Merged

4 tasks

tahmed-dev previously approved these changes May 12, 2021

View reviewed changes

stepanblyschak mentioned this pull request May 21, 2021

SONiC Application Extension PR Tracker #6398

Open

liat-grozovik added the appext Application Extension label May 23, 2021

Merge branch 'master' of github.com:azure/sonic-buildimage into app-e…

7cc9102

…xt-build Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak dismissed tahmed-dev’s stale review via 0652d46 May 31, 2021 06:32

stepanblyschak force-pushed the app-ext-build branch from 0652d46 to 287a7e1 Compare May 31, 2021 06:33

bring back dhcp_relay

abe88c0

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak force-pushed the app-ext-build branch from 287a7e1 to abe88c0 Compare May 31, 2021 06:34

introduce _INSTALL_PYTHON_WHEELS and _INSTALL_DEBS to not install son…

9807d93

…ic-utilities for dockers that dont need it Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

renukamanavalan reviewed Jun 23, 2021

View reviewed changes

files/scripts/swss.sh Show resolved Hide resolved

Merge branch 'master' into app-ext-build

1e3ae92

tahmed-dev approved these changes Jun 29, 2021

View reviewed changes

renukamanavalan merged commit 9de7e68 into sonic-net:master Jun 29, 2021

qiluo-msft reviewed Dec 5, 2025

View reviewed changes

qiluo-msft mentioned this pull request Dec 16, 2025

Move python unit test out of the process of building a docker image target #24873

Open

Conversation

stepanblyschak commented May 12, 2021

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

tahmed-dev left a comment

Choose a reason for hiding this comment

Uh oh!

tahmed-dev May 12, 2021

Choose a reason for hiding this comment

Uh oh!

tahmed-dev Jun 28, 2021

Choose a reason for hiding this comment

Uh oh!

stepanblyschak Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liat-grozovik commented May 13, 2021

Uh oh!

azure-pipelines bot commented May 13, 2021

Uh oh!

liat-grozovik commented May 25, 2021

Uh oh!

azure-pipelines bot commented May 25, 2021

Uh oh!

liat-grozovik commented May 27, 2021

Uh oh!

azure-pipelines bot commented May 27, 2021

Uh oh!

liat-grozovik commented May 30, 2021

Uh oh!

liat-grozovik commented May 31, 2021

Uh oh!

azure-pipelines bot commented May 31, 2021

Uh oh!

liat-grozovik commented Jun 7, 2021

Uh oh!

azure-pipelines bot commented Jun 7, 2021

Uh oh!

stepanblyschak commented Jun 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liat-grozovik commented Jun 15, 2021

Uh oh!

azure-pipelines bot commented Jun 15, 2021

Uh oh!

stepanblyschak commented Jun 15, 2021

Uh oh!

liat-grozovik commented Jun 18, 2021

Uh oh!

azure-pipelines bot commented Jun 18, 2021

Uh oh!

liat-grozovik commented Jun 23, 2021

Uh oh!

Uh oh!

liat-grozovik commented Jun 26, 2021

Uh oh!

renukamanavalan commented Jun 26, 2021

Uh oh!

qiluo-msft Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stepanblyschak Jun 29, 2021 •

edited

Loading

stepanblyschak commented Jun 11, 2021 •

edited

Loading