[device][platform] Add to support as7926-40xfb platform#7577
[device][platform] Add to support as7926-40xfb platform#7577brandonchuang wants to merge 11 commits intosonic-net:masterfrom
Conversation
Switch Vendor: Accton Switch SKU: Accton-AS7926-40XFB CPU: BROADWELL-DE ASIC Vendor: Broadcom Switch ASIC: Broadcom BCM88690 Port Configuration: 40xQSFP28 + 13x QSFP-DD + 2x SFP+ - Why I did it [device][platform] Add to support as7926-40xfb platform - How I did it Implement sysfs and sonic_platform - How to verify it Test sysfs / sensors cmd / sonic_platform / show platform cmd # show platform firmware status # show platform syseeprom # show platform summary # show platform psustatus # psuutil # sfputil # sensors # cat/echo sysfs attributes. - Which release branch to backport (provide reason below if selected) - [ ] 201811 - [ ] 201911 - [ ] 202006 - [X ] 202012 - Description for the changelog Initial commit Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
|
This pull request introduces 26 alerts when merging 4ace65c into 3dc879b - view on LGTM.com new alerts:
|
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Please fix LGTM alerts.
Also please see my related comment: #7479 (comment)
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
|
This pull request introduces 1 alert when merging a295463 into a070f1a - view on LGTM.com new alerts:
|
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
|
This pull request introduces 2 alerts when merging 77dac33 into a070f1a - view on LGTM.com new alerts:
|
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
|
This pull request introduces 1 alert when merging 0243aebdd413aa904d31ebd1ef557a877984f540 into 5bf083a - view on LGTM.com new alerts:
|
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
brandonchuang
force-pushed
the
as7926_40xfb
branch
from
0243aeb to
dce218a
Compare
| @@ -0,0 +1,3 @@ | |||
| as7926-40xfb/sonic_platform-1.0-py3-none-any.whl usr/share/sonic/device/x86_64-accton_as7926_40xfb-r0 | |||
| as7926-40xfb/sonic_platform-1.0-py2-none-any.whl usr/share/sonic/device/x86_64-accton_as7926_40xfb-r0 | |||
There was a problem hiding this comment.
Soon, the master branch will be moving to Debian Bullseye, and Python 2 support will be completely removed. The 202012 branch should have support for using the Python 3 version of the sonic-platform package, if it exists. Therefore, I suggest only installing the Python 3 version of the package. Otherwise, you will need to remove the installation of the Python 2 package in the near future on the master branch.
There was a problem hiding this comment.
Soon, the master branch will be moving to Debian Bullseye, and Python 2 support will be completely removed. The 202012 branch should have support for using the Python 3 version of the sonic-platform package, if it exists. Therefore, I suggest only installing the Python 3 version of the package. Otherwise, you will need to remove the installation of the Python 2 package in the near future on the master branch.
Removed and verified.
| 'Natural Language :: English', | ||
| 'Operating System :: POSIX :: Linux', | ||
| 'Programming Language :: Python :: 3.7', | ||
| 'Programming Language :: Python :: 2.7', |
There was a problem hiding this comment.
Again, suggest removing Python 2 support for the sonic-platform package. Please verify everything works as expected with only the Python 3 package on the 202012 branch.
There was a problem hiding this comment.
Again, suggest removing Python 2 support for the sonic-platform package. Please verify everything works as expected with only the Python 3 package on the 202012 branch.
Removed and verified.
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
2 participants
Signed-off-by: Brandon Chuang brandon_chuang@edge-core.com
Switch Vendor: Accton
Switch SKU: Accton-AS7926-40XFB
CPU: BROADWELL-DE
ASIC Vendor: Broadcom
Switch ASIC: Broadcom BCM88690
Port Configuration: 40xQSFP28 + 13x QSFP-DD + 2x SFP+
Why I did it
[device][platform] Add to support as7926-40xfb platform
How I did it
Implement sysfs and sonic_platform
How to verify it
Test sysfs / sensors cmd / sonic_platform / show platform cmd
show platform firmware status
show platform syseeprom
show platform summary
show platform psustatus
psuutil
sfputil
sensors
cat/echo sysfs attributes.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Initial commit