Revert "[submodule]: Update sonic-swss (#7478)"#7524
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom May 6, 2021
shlomibitton:shlomi_revert
Merged
Revert "[submodule]: Update sonic-swss (#7478)"#7524liat-grozovik merged 1 commit intosonic-net:masterfrom shlomibitton:shlomi_revert
liat-grozovik merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_revert
Conversation
This reverts commit 963e7f4.
Collaborator
|
what is missing here? how to verify the bug? |
Contributor
Author
|
The failing script is port_rates.lua#83, it fails because there are no expected counters for port in counters DB: E.g:
|
liat-grozovik
approved these changes
May 6, 2021
Collaborator
|
once the fix will be available @shlomibitton wil update swss as well |
4 tasks
Collaborator
|
looks like we are missing unit test case here, otherwise, this should be catched by the vstest or sonic-mgmt test, can you add additional test to prevent this from happening again? |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
) This reverts commit 963e7f4.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
) This reverts commit 963e7f4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 963e7f4.
Why I did it
This PR sonic-net/sonic-swss#1646 caused COUNTERS_MAP to be empty even after counters are enabled.
It should be reverted.
A fix for this issue will be provided ASAP.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)