DellEMC: Z9332f media settings#7485
Merged
lguohan merged 6 commits intosonic-net:masterfrom May 5, 2021
Merged
Conversation
jleveque
approved these changes
Apr 29, 2021
Contributor
|
Changes looks good. |
Collaborator
|
does this depends on any other pr? |
Contributor
Author
|
daall
pushed a commit
that referenced
this pull request
May 10, 2021
Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Common method is needed to configure pre-emphasis settings in z9332f platform.
How I did it
Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.
How to verify it
Check APP_DB PORT_TABLE: EthernetX and verify the pre-emphasis settings in NPU.
Which release branch to backport (provide reason below if selected)
Description for the changelog
UT:
media_settings_UT.txt
A picture of a cute animal (not mandatory but encouraged)