[Mellanox] Adopt single way to get fan direction for all ASIC types#7386
Merged
jleveque merged 3 commits intosonic-net:masterfrom May 4, 2021
Merged
[Mellanox] Adopt single way to get fan direction for all ASIC types#7386jleveque merged 3 commits intosonic-net:masterfrom
jleveque merged 3 commits intosonic-net:masterfrom
Conversation
Fan direction is stored at /var/run/hw-management/thermal/fanX_dir 0 - intake 1 - exhaust Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
3 tasks
jleveque
approved these changes
Apr 26, 2021
liat-grozovik
approved these changes
Apr 27, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
daall
pushed a commit
that referenced
this pull request
May 5, 2021
…7386) #### Why I did it Adopt a single way to get fan direction for all ASIC types. It depends on hw-mgmt V.7.0010.2000.2303. Depends on #7419 #### How I did it Originally, the get_direction was implemented by fetching and parsing `/var/run/hw-management/system/fan_dir` on the Spectrum-2 and the Spectrum-3 systems. It isn't supported on the Spectrum system. Now, it is implemented by fetching `/var/run/hw-management/thermal/fanX_dir` for all the platforms. Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…onic-net#7386) #### Why I did it Adopt a single way to get fan direction for all ASIC types. It depends on hw-mgmt V.7.0010.2000.2303. Depends on sonic-net#7419 #### How I did it Originally, the get_direction was implemented by fetching and parsing `/var/run/hw-management/system/fan_dir` on the Spectrum-2 and the Spectrum-3 systems. It isn't supported on the Spectrum system. Now, it is implemented by fetching `/var/run/hw-management/thermal/fanX_dir` for all the platforms. Signed-off-by: Stephen Sun <stephens@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…onic-net#7386) #### Why I did it Adopt a single way to get fan direction for all ASIC types. It depends on hw-mgmt V.7.0010.2000.2303. Depends on sonic-net#7419 #### How I did it Originally, the get_direction was implemented by fetching and parsing `/var/run/hw-management/system/fan_dir` on the Spectrum-2 and the Spectrum-3 systems. It isn't supported on the Spectrum system. Now, it is implemented by fetching `/var/run/hw-management/thermal/fanX_dir` for all the platforms. Signed-off-by: Stephen Sun <stephens@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Adopt a single way to get fan direction for all ASIC types.
It depends on hw-mgmt V.7.0010.2000.2303. Depends on #7419
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
Originally, the get_direction was implemented by fetching and parsing
/var/run/hw-management/system/fan_diron the Spectrum-2 and the Spectrum-3 systems. It isn't supported on the Spectrum system.Now, it is implemented by fetching
/var/run/hw-management/thermal/fanX_dirfor all the platforms.How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)