[container_checker] Exclude the 'always_disabled' container from expected running container list#7217
Merged
yozhao101 merged 2 commits intosonic-net:masterfrom Apr 2, 2021
Merged
Conversation
expected running container list. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Apr 2, 2021
Contributor
|
@yozhao101: If a PR closes an issue, please use a keyword in the description to link the issue. This way the issue will automatically close when the PR merges |
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
approved these changes
Apr 2, 2021
Contributor
Author
I will pay attention to such issue in future. |
daall
added
Request for 202012 Branch
Included in 202012 Branch
and removed
Included in 202012 Branch
labels
daall
pushed a commit
that referenced
this pull request
Apr 2, 2021
…cted running container list (#7217) Signed-off-by: Yong Zhao yozhao@microsoft.com Why I did it Since we introduced a new value always_disabled for the state field in FEATURE table, the expected running container list should exclude the always_diabled containers. This bug was found by nightly test and posted at here: issue. This PR fixes #7210. How I did it I added a logic condition to decide whether the value of state field of a container was always_disabled or not. How to verify it I verified this on the device str-dx010-acs-1. Which release branch to backport (provide reason below if selected) 201811 201911 202006 [ x] 202012
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…cted running container list (sonic-net#7217) Signed-off-by: Yong Zhao yozhao@microsoft.com Why I did it Since we introduced a new value always_disabled for the state field in FEATURE table, the expected running container list should exclude the always_diabled containers. This bug was found by nightly test and posted at here: issue. This PR fixes sonic-net#7210. How I did it I added a logic condition to decide whether the value of state field of a container was always_disabled or not. How to verify it I verified this on the device str-dx010-acs-1. Which release branch to backport (provide reason below if selected) 201811 201911 202006 [ x] 202012
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…cted running container list (sonic-net#7217) Signed-off-by: Yong Zhao yozhao@microsoft.com Why I did it Since we introduced a new value always_disabled for the state field in FEATURE table, the expected running container list should exclude the always_diabled containers. This bug was found by nightly test and posted at here: issue. This PR fixes sonic-net#7210. How I did it I added a logic condition to decide whether the value of state field of a container was always_disabled or not. How to verify it I verified this on the device str-dx010-acs-1. Which release branch to backport (provide reason below if selected) 201811 201911 202006 [ x] 202012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yong Zhao yozhao@microsoft.com
Why I did it
Since we introduced a new value
always_disabledfor thestatefield inFEATUREtable, theexpectedrunning container listshould exclude the
always_diabledcontainers. This bug was found by nightly test and posted at here: issue. This PR fixes #7210.How I did it
I added a logic condition to decide whether the value of
statefield of a container wasalways_disabledor not.How to verify it
I verified this on the device
str-dx010-acs-1.Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)