Skip to content

[Centec][arm64] support new board E530-48s4x and E530-24x2q#7189

Merged
lguohan merged 2 commits intosonic-net:masterfrom
CentecNetworks:sonic-master-20210330-centec-arm64-support-new-board
May 1, 2021
Merged

[Centec][arm64] support new board E530-48s4x and E530-24x2q#7189
lguohan merged 2 commits intosonic-net:masterfrom
CentecNetworks:sonic-master-20210330-centec-arm64-support-new-board

Conversation

@guxianghong
Copy link
Contributor

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Why I did it

  1. Support new board E530-48s4x and E530-24x2q
  2. Platform functions (fan, psu, sfp, etc) improvement
  3. Upgrade sai to v1.7

How I did it

Modify related code in platform and device directory.

How to verify it

Build centec arm64 sonic image, verify platform functions (fan, psu, sfp, etc) on E530 series board.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Mar 30, 2021

This pull request introduces 130 alerts when merging c2f5f69823aaa19edebeaa931c39154dfd6fda61 into 67c5799 - view on LGTM.com

new alerts:

  • 88 for Unused import
  • 20 for Wrong number of arguments in a class instantiation
  • 8 for Unreachable code
  • 4 for Module imports itself
  • 4 for Except block handles 'BaseException'
  • 4 for 'import *' may pollute namespace
  • 2 for Testing equality to None

@lguohan
Copy link
Collaborator

lguohan commented Mar 30, 2021

can you fix lgtm first?

@guxianghong
Copy link
Contributor Author

can you fix lgtm first?

Okay, we'll fix these alerts as soon as possible.

@LuiSzee LuiSzee force-pushed the sonic-master-20210330-centec-arm64-support-new-board branch from c2f5f69 to feac387 Compare March 31, 2021 02:23
@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2021

This pull request introduces 28 alerts when merging feac387aec2667c61c23ba0d82399258631939b8 into ecaf97d - view on LGTM.com

new alerts:

  • 20 for Wrong number of arguments in a class instantiation
  • 4 for Module imports itself
  • 4 for 'import *' may pollute namespace

@LuiSzee LuiSzee force-pushed the sonic-master-20210330-centec-arm64-support-new-board branch from feac387 to 379d4ea Compare March 31, 2021 03:42
@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2021

This pull request introduces 20 alerts when merging 379d4eac3da6334efbb4783675e568883f8cfda1 into ecaf97d - view on LGTM.com

new alerts:

  • 20 for Wrong number of arguments in a class instantiation

    1. support new board E530-48s4x E530-24x2q
    2. optimize platform driver for Centec TsingMa board
@LuiSzee LuiSzee force-pushed the sonic-master-20210330-centec-arm64-support-new-board branch from 379d4ea to 575758c Compare March 31, 2021 05:40
@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2021

This pull request introduces 20 alerts when merging 575758c into ecaf97d - view on LGTM.com

new alerts:

  • 20 for Wrong number of arguments in a class instantiation

@guxianghong
Copy link
Contributor Author

retest this please

@guxianghong guxianghong force-pushed the sonic-master-20210330-centec-arm64-support-new-board branch from ee2aedc to 575758c Compare April 6, 2021 01:54
@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2021

This pull request introduces 20 alerts when merging 575758c into 6d83a42 - view on LGTM.com

new alerts:

  • 20 for Wrong number of arguments in a class instantiation

@guxianghong
Copy link
Contributor Author

It looks like all these new alerts are false positives, centec platform utilities will not call other vendor's platfom utility. @lguohan please help to review this PR, thanks.

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2021

This pull request introduces 20 alerts when merging fd35b94 into 39d877c - view on LGTM.com

new alerts:

  • 20 for Wrong number of arguments in a class instantiation

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guxianghong
Copy link
Contributor Author

Please help to review&merge this PR, @lguohan @jleveque, thanks very much.

@lguohan lguohan merged commit be4cf09 into sonic-net:master May 1, 2021
@mssonicbld
Copy link
Collaborator

/AzurePipelines run

LuiSzee added a commit to CentecNetworks/sonic-buildimage that referenced this pull request May 21, 2021
…t#7189)

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Co-authored-by: shi lei <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
…t#7189)

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Co-authored-by: shi lei <[email protected]>
LuiSzee added a commit to CentecNetworks/sonic-buildimage that referenced this pull request Jul 29, 2021
…t#7189)

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Co-authored-by: shi lei <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…t#7189)

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Co-authored-by: shi lei <[email protected]>
LuiSzee added a commit to CentecNetworks/sonic-buildimage that referenced this pull request Aug 20, 2021
…t#7189)

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Co-authored-by: shi lei <[email protected]>
AlanYoush added a commit to CentecNetworks/sonic-buildimage that referenced this pull request Nov 25, 2023
…t#7189)

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Signed-off-by: yoush <[email protected]>
centecqianj pushed a commit to CentecNetworks/sonic-buildimage that referenced this pull request Aug 9, 2024
…t#7189)

1. support new board E530-48s4x E530-24x2q
2. optimize platform driver for Centec TsingMa board

Signed-off-by: yoush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants