Skip to content

[Mellanox] Fix for all Spectrum based systems: SAI profile speed configurations#7119

Merged
lguohan merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_fix_sai_profiles_speed_SPC1
Apr 19, 2021
Merged

[Mellanox] Fix for all Spectrum based systems: SAI profile speed configurations#7119
lguohan merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_fix_sai_profiles_speed_SPC1

Conversation

@shlomibitton
Copy link
Contributor

@shlomibitton shlomibitton commented Mar 22, 2021

Why I did it

SAI profile files speed configuration have wrong bitmap value for 10/50G speed option.

How I did it

Fix to the correct value for all SPC1 devices.
For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR
For 50G added 50GB_SR2

This bitmask represents all the options available for interface type and some were missing.
Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile.

How to verify it

Configure on these platforms ports with 10/50G speed using this fix.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
@shlomibitton shlomibitton requested a review from jleveque as a code owner March 22, 2021 16:01
@liat-grozovik liat-grozovik changed the title [Mellanox] Fix for all SPC1 devices sai profile speed configurations [Mellanox] Fix for all Spectrum based systems: SAI profile speed configurations Mar 24, 2021
@lguohan
Copy link
Collaborator

lguohan commented Mar 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lguohan
Copy link
Collaborator

lguohan commented Mar 28, 2021

can you describe the 10g/50g issue? please describe the issue in more details.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add more descriptions.

@liat-grozovik
Copy link
Collaborator

@lguohan description was added to the PR. Please review.

@lguohan
Copy link
Collaborator

lguohan commented Mar 31, 2021

can you enumerate what iftype are added?

@dprital
Copy link
Collaborator

dprital commented Apr 2, 2021

can you enumerate what iftype are added?

@lguohan - iftype were not added. This PR fix wrong bit map setting (preliminary set) for 10G and 50G interfaces on SAI XML file.
The bit maps for 10G and 50G were fixed to the correct value.

@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Apr 4, 2021

can you enumerate what iftype are added?

@lguohan - iftype were not added. This PR fix wrong bit map setting (preliminary set) for 10G and 50G interfaces on SAI XML file.
The bit maps for 10G and 50G were fixed to the correct value.

this was added to the PR message itself few days ago.

"
Fix to the correct value for all SPC1 devices.
10G: changed from 2096 to 28700
50G: changed from 3221225472 to 3221487616

This bitmask represents all the options available for interface type and some were missing.
Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile.
"

@lguohan Can you please approve?

@liat-grozovik
Copy link
Collaborator

@lguohan do you have any further comment or can i move forward and merge?
BTW the change is already part of 201911.

@lguohan
Copy link
Collaborator

lguohan commented Apr 12, 2021

i checked the bitmap, there is add.

3221225472 =0xC000 0000
3221487616 = 0xC004 0000

same for the 10G.

please add information I have asked.

@shlomibitton
Copy link
Contributor Author

@lguohan these modes were added:

10G
speed_capability->mode_10GB_CX4_XAUI = TRUE;
speed_capability->mode_10GB_KX4 = TRUE;
speed_capability->mode_10GB_KR = TRUE;
speed_capability->mode_10GB_SR = TRUE;
speed_capability->mode_10GB_ER_LR = TRUE;

50G
speed_capability->mode_50GB_SR2 = TRUE;

@lguohan lguohan merged commit b0bfa2b into sonic-net:master Apr 19, 2021
daall pushed a commit that referenced this pull request Apr 21, 2021
…igurations (#7119)

Fix to the correct value for all SPC1 devices.
For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR
For 50G added 50GB_SR2

This bitmask represents all the options available for interface type and some were missing.
Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile.

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
…igurations (sonic-net#7119)

Fix to the correct value for all SPC1 devices.
For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR
For 50G added 50GB_SR2

This bitmask represents all the options available for interface type and some were missing.
Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile.

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
@shlomibitton shlomibitton deleted the shlomi_fix_sai_profiles_speed_SPC1 branch June 2, 2021 12:35
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…igurations (sonic-net#7119)

Fix to the correct value for all SPC1 devices.
For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR
For 50G added 50GB_SR2

This bitmask represents all the options available for interface type and some were missing.
Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile.

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants