[Mellanox] Fix for all Spectrum based systems: SAI profile speed configurations#7119
[Mellanox] Fix for all Spectrum based systems: SAI profile speed configurations#7119lguohan merged 1 commit intosonic-net:masterfrom shlomibitton:shlomi_fix_sai_profiles_speed_SPC1
Conversation
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
can you describe the 10g/50g issue? please describe the issue in more details. |
|
@lguohan description was added to the PR. Please review. |
|
can you enumerate what iftype are added? |
@lguohan - iftype were not added. This PR fix wrong bit map setting (preliminary set) for 10G and 50G interfaces on SAI XML file. |
this was added to the PR message itself few days ago. " This bitmask represents all the options available for interface type and some were missing. @lguohan Can you please approve? |
|
@lguohan do you have any further comment or can i move forward and merge? |
|
i checked the bitmap, there is add. 3221225472 =0xC000 0000 same for the 10G. please add information I have asked. |
|
@lguohan these modes were added: 10G 50G |
…igurations (#7119) Fix to the correct value for all SPC1 devices. For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR For 50G added 50GB_SR2 This bitmask represents all the options available for interface type and some were missing. Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
…igurations (sonic-net#7119) Fix to the correct value for all SPC1 devices. For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR For 50G added 50GB_SR2 This bitmask represents all the options available for interface type and some were missing. Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
…igurations (sonic-net#7119) Fix to the correct value for all SPC1 devices. For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR For 50G added 50GB_SR2 This bitmask represents all the options available for interface type and some were missing. Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Why I did it
SAI profile files speed configuration have wrong bitmap value for 10/50G speed option.
How I did it
Fix to the correct value for all SPC1 devices.
For 10G added 10GB_CX4_XAUI, 10GB_KX4, 10GB_KR, 10GB_SR and 10GB_ER_LR
For 50G added 50GB_SR2
This bitmask represents all the options available for interface type and some were missing.
Note: it was working just fine if you were setting the value from SONiC CLI but not from the default SAI Profile.
How to verify it
Configure on these platforms ports with 10/50G speed using this fix.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)