[201911][dockers][supervisor] Increase event buffer size for process exit listener; Set all event buffer sizes to 1024#7106
Merged
jleveque merged 1 commit intosonic-net:201911from Mar 29, 2021
jleveque:sup_event_buf_size_201911
Merged
[201911][dockers][supervisor] Increase event buffer size for process exit listener; Set all event buffer sizes to 1024#7106jleveque merged 1 commit intosonic-net:201911from jleveque:sup_event_buf_size_201911
jleveque merged 1 commit intosonic-net:201911from
jleveque:sup_event_buf_size_201911
Conversation
…exit listener Backpor of #7083 to the 201911 branch
4 tasks
lguohan
approved these changes
Mar 28, 2021
qiluo-msft
approved these changes
Mar 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7083 to the 201911 branch.
Why I did it
To prevent error messages like the following from being logged:
This is basically an addendum to #5247, which increased the event buffer size for dependent-startup. While supervisor-proc-exit-listener doesn't subscribe to as many events as dependent-startup, there is still a chance some containers (like swss, as in the example above) have enough processes running to cause an overflow of the default buffer size of 10.
This is especially important for preventing erroneous log_analyzer failures in the sonic-mgmt repo regression tests, which have started occasionally causing PR check builds to fail. Example here.
I set all supervisor-proc-exit-listener event buffer sizes to 1024, and also updated all dependent-startup event buffer sizes to 1024, as well, to keep things simple, unified, and allow headroom so that we will not need to adjust these values frequently, if at all.