SONiC Yang model for PORTCHANNEL_INTERFACE table#7034
Merged
lguohan merged 7 commits intosonic-net:masterfrom Mar 28, 2021
Merged
SONiC Yang model for PORTCHANNEL_INTERFACE table#7034lguohan merged 7 commits intosonic-net:masterfrom
lguohan merged 7 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Arthi Sivanantham <[email protected]>
|
|
Collaborator
|
can you sign cla? |
lguohan
reviewed
Mar 12, 2021
lguohan
reviewed
Mar 12, 2021
4 tasks
Signed-off-by: Arthi Sivanantham <[email protected]>
ArthiSivanantham
force-pushed
the
sonic_portchannel_interface
branch
from
57fdddd to
cf55354
Compare
Contributor
Author
Done |
praveen-li
reviewed
Mar 12, 2021
added 3 commits
March 15, 2021 16:52
Signed-off-by: Arthi Sivanantham <[email protected]>
… sonic_portchannel_interface
Signed-off-by: Arthi Sivanantham <[email protected]>
ArthiSivanantham
force-pushed
the
sonic_portchannel_interface
branch
from
b712709 to
cbdec66
Compare
2. Rename IP address list for consistency Signed-off-by: Arthi Sivanantham <[email protected]>
praveen-li
reviewed
Mar 17, 2021
praveen-li
requested changes
Mar 18, 2021
2. Add negative test case for IP addr assignment on a non existent PortChannel Signed-off-by: Arthi Sivanantham <[email protected]>
rathnasabapathyv
approved these changes
Mar 18, 2021
praveen-li
approved these changes
Mar 23, 2021
| "sonic-portchannel:sonic-portchannel": { | ||
| "sonic-portchannel:PORTCHANNEL": { | ||
| "PORTCHANNEL_LIST": [{ | ||
| "name": "PortChannel0001" |
Member
There was a problem hiding this comment.
Better to add admin_status, since it is mandatory. Libyang may throw error about mandatory before leafref and the test case may fail. So better to keep one failure scenario in the test. Thx.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lguohan
approved these changes
Mar 28, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
) * SONiC Yang model for PORTCHANNEL_INTERFACE table Signed-off-by: Arthi Sivanantham <[email protected]>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
) * SONiC Yang model for PORTCHANNEL_INTERFACE table Signed-off-by: Arthi Sivanantham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthi Sivanantham [email protected]
Why I did it
SONiC YANG model support for PORTCHANNEL_INTERFACE table.
How I did it
Defined PORTCHANNEL_INTERFACE_IPADDR_LIST YANG list based on config-DB schema.
How to verify it
sonic_yang_models package build
Which release branch to backport (provide reason below if selected)
Description for the changelog
SONiC YANG model support for PORTCHANNEL_INTERFACE table in config DB.