DellEMC Z9332f pre-emphasis settings#6984
Merged
daall merged 2 commits intosonic-net:masterfrom Apr 5, 2021
Merged
Conversation
Contributor
Author
|
The build failure is due to sonic-net/sonic-swss#1611 not merged in master branch. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@aravindmani-1 the submodule pointer has been updated but the build is still failing, can you check, please? |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 6984 in repo Azure/sonic-buildimage |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @daall , Can we add the following fields (main, pre1,pre2,pre3, post1,post2, post3) in https://github.com/Azure/sonic-buildimage/blob/2c9454e86af7311e9ebc81efb734782969550693/src/sonic-device-data/tests/media_checker#L9 and retest. |
Collaborator
|
media_setting feature is developed by dell, can dell have an internal sync and resolve? |
4 tasks
Contributor
Author
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
daall
approved these changes
Apr 5, 2021
daall
pushed a commit
that referenced
this pull request
Apr 5, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Added the pre-emphasis settings for DellEMC Z9332f platform.
How I did it
Added media_settings.json file to program the pre-emphasis settings.
How to verify it
Check syslogs of PMON,SWSS dockers and check the pre-emphasis values programmed in NPU shell.
Which release branch to backport (provide reason below if selected)
Description for the changelog
UT:
z9332f_media_settings_UT.txt
A picture of a cute animal (not mandatory but encouraged)