[sonic-yang-models] fix ip_type value in test cases#6968
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 28, 2021
Merged
[sonic-yang-models] fix ip_type value in test cases#6968lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
Author
praveen-li
approved these changes
Mar 4, 2021
| "SRC_IP": "10.176.0.0/15", | ||
| "PRIORITY": 999980, | ||
| "IP_TYPE": "IPV4ANY" | ||
| "IP_TYPE": "IPv4ANY" |
Member
There was a problem hiding this comment.
As per
typedef ip_type {
type enumeration {
enum ANY;
enum IP;
enum NON_IP;
enum IPV4;
enum IPV6;
enum IPv4ANY;
enum NON_IP4;
enum IPv6ANY;
enum NON_IPv6;
enum ARP;
}
}
This looks Good to me. Though I'm thinking, should yang models support both lowercase and uppercase.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lguohan
approved these changes
Mar 28, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
IPV4ANY is not valid value, fix to IPv4ANY without this change, test case failed sometimes when the validation on IP_TYPE happens first and then PACKET_ACTION.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
IPV4ANY is not valid value, fix to IPv4ANY without this change, test case failed sometimes when the validation on IP_TYPE happens first and then PACKET_ACTION.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com