Split yang tests into multiple files by joyas-joseph · Pull Request #6939 · sonic-net/sonic-buildimage

joyas-joseph · 2021-03-02T19:31:35Z

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Joyas Joseph joyas_joseph@dell.com

Link to previous PR #3730

Why I did it

Add manageability to the yang model tests

How I did it

By splitting the tests and config data for the tests into multiple files.
The "tests" directory contains all the tests and the "tests_config" directory contains the configs used for the tests.

New tests can be added in new json files.

How to verify it

Build the sonic_yang_models package

Which release branch to backport (provide reason below if selected)

201811
201911
202006
202012

Description for the changelog

Improve yang model test manageability

A picture of a cute animal (not mandatory but encouraged)

and config data for the tests into multiple files. The "tests" directory contains all the tests and the "tests_config" directory contains the configs used for the tests. New tests can be added in new json files. Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

lguohan · 2021-03-04T18:55:30Z

can you check the build failure?

…test_split

Also, add missed data for SAMPLE_CONFIG_DB_JSON and SAMPLE_CONFIG_DB_JSON_1 Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph · 2021-03-05T02:16:09Z

can you check the build failure?

I have updated the PR. All checks pass now.

joyas-joseph · 2021-03-09T18:53:29Z

@praveen-li Could you please review this?

praveen-li · 2021-03-09T19:10:04Z

@praveen-li Could you please review this?

sure I'll have a look today thanks

praveen-li

Thanks for starting this effort.

src/sonic-yang-mgmt/tests/libyang-python-tests/test_sonic_yang.py

src/sonic-yang-models/tests/yang_model_tests/test_yang_model.py

src/sonic-yang-models/tests/yang_model_tests/tests_config/except.json

…test_split Address review comments Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph · 2021-03-16T06:15:03Z

retest this please

src/sonic-yang-models/tests/yang_model_tests/tests/port.json

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

praveen-li · 2021-03-18T18:42:30Z

@joyas-joseph:
Add 'Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com' as well in this PR.
Also, add a reference to the previous PR in the commit log, I think: #3730

So that questions about original content can be redirected to me in the future using GITHUB blame.

joyas-joseph · 2021-03-19T18:53:15Z

@joyas-joseph:
Add 'Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com' as well in this PR.
Also, add a reference to the previous PR in the commit log, I think: #3730

So that questions about original content can be redirected to me in the future using GITHUB blame.

Updated the PR.

praveen-li · 2021-03-19T21:53:22Z

@joyas-joseph thanks

@lguohan kindly merge this pr today if possible so that other prs can be on top of it. Thx a lot.

lguohan · 2021-03-28T07:59:14Z

can you help to resolve the conflict?

…test_split Merge and resolve conflicts Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

praveen-li · 2021-03-30T00:09:08Z

device/arista/x86_64-arista_7260cx3_64/Arista-7260CX3-C64/buffers_defaults_t0.j2

@@ -0,0 +1,46 @@
+{%- set default_cable = '5m' %}


Hi Joyesh, We need rebase here. Seems something got messed up here, these files should not be in this diff. I remember I approve this PR, but kindly fix this last comment and I'll approve again, thanks a lot.....I
on Double check, I think It is right rebase. I am not sure, why one commit shows the extra delta.

praveen-li · 2021-03-30T00:13:28Z

@lguohan kindly merge this pr before other yang PRs if possible, so that new prs can be on top of it. Thx a lot.

lguohan · 2021-03-30T15:29:16Z

@joyas-joseph , more yang related pr has been merged, can you resolve the conflict?

…test_split Merge and resolve conflicts Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

bhavini-gada · 2021-03-30T20:18:38Z

@lguohan - Can you please merge this before merging any new PRs ?

* Add manageability to the yang model tests by splitting the tests and config data for the tests into multiple files. The "tests" directory contains all the tests and the "tests_config" directory contains the configs used for the tests. New tests can be added in new json files. Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph requested a review from lguohan as a code owner March 2, 2021 19:31

lguohan added the YANG YANG model related changes label Mar 4, 2021

joyas-joseph added 2 commits March 4, 2021 12:43

Merge branch 'master' of github.com:Azure/sonic-buildimage into yang_…

9e15665

…test_split

Update tests in sonic-yang-mgmt based on changes in sonig-yang-models

30850c8

Also, add missed data for SAMPLE_CONFIG_DB_JSON and SAMPLE_CONFIG_DB_JSON_1 Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

praveen-li reviewed Mar 10, 2021

View reviewed changes

joyas-joseph added 2 commits March 9, 2021 21:01

Merge branch 'master' of github.com:Azure/sonic-buildimage into yang_…

543db9f

…test_split Address review comments Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

Update with latest test_sonic_yang.py

39d4449

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph changed the title ~~Improve yang model test manageability~~ Split yang tests into multiple files Mar 10, 2021

anand-kumar-subramanian previously approved these changes Mar 11, 2021

View reviewed changes

Address review comments.

dff550b

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph dismissed anand-kumar-subramanian’s stale review via dff550b March 11, 2021 23:45

rathnasabapathyv reviewed Mar 16, 2021

View reviewed changes

src/sonic-yang-models/tests/yang_model_tests/tests/port.json Outdated Show resolved Hide resolved

joyas-joseph added 2 commits March 16, 2021 11:11

Merge from azure/master

c5c37e6

Update tests based on latest master

d60b020

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

anand-kumar-subramanian previously approved these changes Mar 18, 2021

View reviewed changes

praveen-li previously approved these changes Mar 19, 2021

View reviewed changes

Merge branch 'master' of github.com:Azure/sonic-buildimage into yang_…

c5934f6

…test_split Merge and resolve conflicts Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph dismissed stale reviews from praveen-li and anand-kumar-subramanian via c5934f6 March 29, 2021 18:47

anand-kumar-subramanian previously approved these changes Mar 29, 2021

View reviewed changes

lguohan previously approved these changes Mar 29, 2021

View reviewed changes

praveen-li requested changes Mar 30, 2021

View reviewed changes

praveen-li previously approved these changes Mar 30, 2021

View reviewed changes

Merge branch 'master' of github.com:Azure/sonic-buildimage into yang_…

b6b7770

…test_split Merge and resolve conflicts Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph dismissed stale reviews from praveen-li, lguohan, and anand-kumar-subramanian via b6b7770 March 30, 2021 17:52

anand-kumar-subramanian previously approved these changes Mar 30, 2021

View reviewed changes

Resolve conflicts

444d929

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>

joyas-joseph dismissed anand-kumar-subramanian’s stale review via 444d929 March 30, 2021 17:58

praveen-li approved these changes Mar 31, 2021

View reviewed changes

lguohan approved these changes Mar 31, 2021

View reviewed changes

lguohan merged commit 0b64dc3 into sonic-net:master Mar 31, 2021

Conversation

joyas-joseph commented Mar 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

lguohan commented Mar 4, 2021

Uh oh!

joyas-joseph commented Mar 5, 2021

Uh oh!

joyas-joseph commented Mar 9, 2021

Uh oh!

praveen-li commented Mar 9, 2021

Uh oh!

praveen-li left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joyas-joseph commented Mar 16, 2021

Uh oh!

Uh oh!

praveen-li commented Mar 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyas-joseph commented Mar 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praveen-li commented Mar 19, 2021

Uh oh!

lguohan commented Mar 28, 2021

Uh oh!

praveen-li Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

praveen-li commented Mar 30, 2021

Uh oh!

lguohan commented Mar 30, 2021

Uh oh!

bhavini-gada commented Mar 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

joyas-joseph commented Mar 2, 2021 •

edited

Loading

praveen-li commented Mar 18, 2021 •

edited

Loading

joyas-joseph commented Mar 19, 2021 •

edited

Loading

praveen-li Mar 30, 2021 •

edited

Loading