Merged
Conversation
stcheng
reviewed
Jun 9, 2017
dockers/docker-fpm-quagga/start.sh
Outdated
Contributor
There was a problem hiding this comment.
a sample file of bgp_admin.yml file could be provided in sonic-cfggen tests folder.
lguohan
reviewed
Jun 9, 2017
Collaborator
There was a problem hiding this comment.
add comment: "shutdown down all ipv4 neighbors when "neighbor_ip" = 0.0.0.0
lguohan
reviewed
Jun 9, 2017
Collaborator
There was a problem hiding this comment.
can we use the full names here. su -> summary
Collaborator
|
why not change this file https://github.com/Azure/sonic-utilities/blob/master/config/main.py to add bgp neighbor shut/unshut functionality? why add another script to do this? I feel this utilities should be part of sonic-utilities. |
Contributor
Author
|
I agree. Planned to add into sonic-utilities later. |
Contributor
Author
|
Close it by now as we might need more discussion on the default behavior of bgp admin state. |
Contributor
Author
|
Set default admin state to ON and add build option to SHUTDOWN_BGP_ON_START to set them as OFF. |
taoyl-ms
changed the title
lguohan
approved these changes
Jun 12, 2017
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Nov 22, 2018
sairedis: * d146572 2018-11-22 | Fix interface name used on link message using lane map (sonic-net#386) swss: * c74dc60 2018-11-22 | [vstest]: use eth1~32 as physical interface name in vs docker (sonic-net#700) (HEAD -> master, origin/master, origin/HEAD) [lguohan] * 6007e7f 2018-11-22 | [portmgrd]: Fix setting default port admin status and MTU (sonic-net#691) [stepanblyschak] * 6c70f6d 2018-11-22 | [portsorch] Fix port queue index init bug (sonic-net#505) [yangbashuang] * 70ac79b 2018-11-21 | [gitignore]: Update all binary names in the ignore list (sonic-net#698) [Shuotian Cheng] * 2a3626c 2018-11-21 | [test]: Remove duplicate legacy ACL tests (sonic-net#699) [Shuotian Cheng] * 8099811 2018-11-20 | [aclorch]: Remove unnecessary warning message (sonic-net#696) [Shuotian Cheng] * 63d8ebc 2018-11-18 | [portsorch]: Remove duplicate local variables - port (sonic-net#690) [Shuotian Cheng] * 28dc042 2018-11-18 | Remove default docker name value of swss. (sonic-net#692) [Jipan Yang] Signed-off-by: Guohan Lu <[email protected]>
lguohan
added a commit
that referenced
this pull request
Nov 22, 2018
* syncd changes to disk and add e1000 driver to sonic vm * add pg_profile_lookup.ini Signed-off-by: Guohan Lu <[email protected]> * update swss and sairedis sairedis: * d146572 2018-11-22 | Fix interface name used on link message using lane map (#386) swss: * c74dc60 2018-11-22 | [vstest]: use eth1~32 as physical interface name in vs docker (#700) (HEAD -> master, origin/master, origin/HEAD) [lguohan] * 6007e7f 2018-11-22 | [portmgrd]: Fix setting default port admin status and MTU (#691) [stepanblyschak] * 6c70f6d 2018-11-22 | [portsorch] Fix port queue index init bug (#505) [yangbashuang] * 70ac79b 2018-11-21 | [gitignore]: Update all binary names in the ignore list (#698) [Shuotian Cheng] * 2a3626c 2018-11-21 | [test]: Remove duplicate legacy ACL tests (#699) [Shuotian Cheng] * 8099811 2018-11-20 | [aclorch]: Remove unnecessary warning message (#696) [Shuotian Cheng] * 63d8ebc 2018-11-18 | [portsorch]: Remove duplicate local variables - port (#690) [Shuotian Cheng] * 28dc042 2018-11-18 | Remove default docker name value of swss. (#692) [Jipan Yang] Signed-off-by: Guohan Lu <[email protected]>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Oct 3, 2019
Submodule src/sonic-utilities 2d721de..fb5902f: > Revert "[fast reboot] kill teamd docker directly (sonic-net#683)" (sonic-net#690) Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
that referenced
this pull request
Oct 3, 2019
Submodule src/sonic-utilities 2d721de..fb5902f: > Revert "[fast reboot] kill teamd docker directly (#683)" (#690) Signed-off-by: Ying Xie <[email protected]>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Shu0T1an ChenG <[email protected]>
kcudnik
added a commit
that referenced
this pull request
Dec 5, 2020
[sairedis] Advance sairedis pointer to support cmd zmq flag [meta] Use memcpy instead of cast to prevent strict-aliasing error (#723) [vslib]Add MACsec forward and filters to HostInterfaceInfo (#719) [vslib] Add StateBase function for MACsec (#717) Add support for default zmq synchronous mode flag (#711) [syncd] Code clean (#720) [sairedis] Remove custom bulk fdb methods (#710) [vslib]Add MACsec Filters (#713) [vslib]Add MACsec Forwarder (#714) [vslib]Add MACsec Manager (#715) Add helper functions, findObjects and dumpObject (#716) Code clean refactor (#712) [vslib] Fix CorePortIndexMap log line (#708) [meta] Use custom hash in SaiObjectCollection (#709) Fix LGTM localtime function warnings (#707) [vs] VoQ Switch objects initialization - Local Port OID mapping to System Ports (#703) Code style refactor (#705) [vs] Initialization of VOQ switch objects (#702) [vs] SAI support for VOQ switches - Switch State Initialization (#701) Add MACsec meta methods (#704) [vs] SAI support for VOQ switches (#698) [vs] SAI support for VOQ switches - Core Port Index Map File parser (#700) [vs] SAI support for VoQ switch - Core Port Index Map Container (#699) [syncd][sairedis] Change pub/sub model to push/pull in zmq notification (#695) [syncd] Use lua script to update db when using bulk api (#690) [syncd] Fix bulk api object type for next hop group members (#685) Add FlexCounter for MACsec SA (#684)
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…t#6064) [sairedis] Advance sairedis pointer to support cmd zmq flag [meta] Use memcpy instead of cast to prevent strict-aliasing error (sonic-net#723) [vslib]Add MACsec forward and filters to HostInterfaceInfo (sonic-net#719) [vslib] Add StateBase function for MACsec (sonic-net#717) Add support for default zmq synchronous mode flag (sonic-net#711) [syncd] Code clean (sonic-net#720) [sairedis] Remove custom bulk fdb methods (sonic-net#710) [vslib]Add MACsec Filters (sonic-net#713) [vslib]Add MACsec Forwarder (sonic-net#714) [vslib]Add MACsec Manager (sonic-net#715) Add helper functions, findObjects and dumpObject (sonic-net#716) Code clean refactor (sonic-net#712) [vslib] Fix CorePortIndexMap log line (sonic-net#708) [meta] Use custom hash in SaiObjectCollection (sonic-net#709) Fix LGTM localtime function warnings (sonic-net#707) [vs] VoQ Switch objects initialization - Local Port OID mapping to System Ports (sonic-net#703) Code style refactor (sonic-net#705) [vs] Initialization of VOQ switch objects (sonic-net#702) [vs] SAI support for VOQ switches - Switch State Initialization (sonic-net#701) Add MACsec meta methods (sonic-net#704) [vs] SAI support for VOQ switches (sonic-net#698) [vs] SAI support for VOQ switches - Core Port Index Map File parser (sonic-net#700) [vs] SAI support for VoQ switch - Core Port Index Map Container (sonic-net#699) [syncd][sairedis] Change pub/sub model to push/pull in zmq notification (sonic-net#695) [syncd] Use lua script to update db when using bulk api (sonic-net#690) [syncd] Fix bulk api object type for next hop group members (sonic-net#685) Add FlexCounter for MACsec SA (sonic-net#684)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
…nic-net#690) This reverts commit 592413b.
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
* [syncd] Use lua script to update db when using bulk api * [syncd] Handle multi keys create with empty attribute list * [syncd] Fix emplace back on non existing object * [syncd] Update redis client to use corrected del method name
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Mar 7, 2025
…omatically (sonic-net#690) #### Why I did it src/sonic-swss-common ``` * e787abe - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-swss-common:202411 to 202412 (#16) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
kewei-arista
pushed a commit
to kewei-arista/sonic-buildimage
that referenced
this pull request
Dec 8, 2025
…D automatically (sonic-net#24736) #### Why I did it src/sonic-platform-daemons ``` * a4f2b83 - (HEAD -> master, origin/master, origin/HEAD) Add suport for liquid cooling leakage detection (sonic-net#690) (17 hours ago) [Yuanzhe] ``` #### How I did it #### How to verify it #### Description for the changelog
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 18, 2025
…D automatically (sonic-net#24736) #### Why I did it src/sonic-platform-daemons ``` * a4f2b83 - (HEAD -> master, origin/master, origin/HEAD) Add suport for liquid cooling leakage detection (sonic-net#690) (17 hours ago) [Yuanzhe] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Dawei Huang <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…D automatically (sonic-net#24736) #### Why I did it src/sonic-platform-daemons ``` * a4f2b83 - (HEAD -> master, origin/master, origin/HEAD) Add suport for liquid cooling leakage detection (sonic-net#690) (17 hours ago) [Yuanzhe] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: xiaweijiang <[email protected]>
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
…D automatically (sonic-net#24736) #### Why I did it src/sonic-platform-daemons ``` * a4f2b83 - (HEAD -> master, origin/master, origin/HEAD) Add suport for liquid cooling leakage detection (sonic-net#690) (17 hours ago) [Yuanzhe] ``` #### How I did it #### How to verify it #### Description for the changelog
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…D automatically (sonic-net#24736) #### Why I did it src/sonic-platform-daemons ``` * a4f2b83 - (HEAD -> master, origin/master, origin/HEAD) Add suport for liquid cooling leakage detection (sonic-net#690) (17 hours ago) [Yuanzhe] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.