[yang_models]: Update extension yang and types yang with new yang ext… by maheshwari-mayank · Pull Request #6861 · sonic-net/sonic-buildimage

maheshwari-mayank · 2021-02-23T11:17:03Z

…ensions and types respectively.

Why I did it

Added new sonic yang extensions and new yang type definitions.

How I did it

Updated new yang extensions in sonic-extension.yang. Updated new yang types in sonic-types.yang.

How to verify it

These are just new extensions and type definitions. No verification required.

Which release branch to backport (provide reason below if selected)

Description for the changelog

Added new yang extensions and yang type definitions.

A picture of a cute animal (not mandatory but encouraged)

…ensions and types respectively.

ghost · 2021-02-23T11:17:17Z

All CLA requirements met.

src/sonic-yang-models/yang-models/sonic-types.yang

arlakshm · 2021-02-25T18:36:10Z

  				pattern "rs|fc|none";

can we use stypes fec-mode here ?

Refers to: src/sonic-yang-models/yang-models/sonic-port.yang:88 in 76e9a18. [](commit_id = 76e9a18, deletion_comment = False)

src/sonic-yang-models/yang-models/sonic-extension.yang

…pes and sonic-extension

src/sonic-yang-models/yang-models/sonic-extension.yang

src/sonic-yang-models/yang-models/sonic-types.yang

src/sonic-yang-models/yang-models/sonic-extension.yang

src/sonic-yang-models/yang-models/sonic-types.yang

src/sonic-yang-models/yang-models/sonic-device_metadata.yang

src/sonic-yang-models/yang-models/sonic-extension.yang

… comments.

maheshwari-mayank · 2021-03-18T17:45:38Z

retest this please

maheshwari-mayank · 2021-03-18T17:52:44Z

retest

anand-kumar-subramanian · 2021-03-19T04:39:57Z

retest this please

anand-kumar-subramanian · 2021-03-24T16:34:16Z

@lguohan Can you please trigger the retest of this please?

arlakshm · 2021-03-24T18:31:46Z

@lguohan Can you please trigger the retest of this please?

@anand-kumar-subramanian, I have restarted the Test kvmtest-t0 tests.

anand-kumar-subramanian · 2021-04-06T18:28:52Z

@arlakshm The failure is not because of Mayank's changes. Can you please restart this again.

src/sonic-yang-models/yang-models/sonic-extension.yang

src/sonic-yang-models/yang-models/sonic-types.yang

zhangyanzhao · 2021-09-02T17:37:34Z

BRCM team will handle this. Rajesh Velamakanni.

zhangyanzhao · 2021-09-02T17:42:06Z

Guohan will create a new PR for J2 template usage, then team will come back to revisit this one to proceed.

zhangyanzhao · 2021-09-16T17:19:46Z

@lguohan can you please link the J2 template PR to this one ? Thanks.

zhangyanzhao · 2021-09-30T17:32:54Z

@lguohan will raise the template PR by next meeting.

zhangyanzhao · 2021-10-07T17:07:57Z

template PR is linked, but see build failure which Guohan is checking.

…to Azure-master

Sonic-mgmt-common already has CVL specific extensions. External yangs generated from templates will be copied to sonic-mgmt-common repo.

…ang j2 file to yang-template directory.

zhangyanzhao · 2021-11-18T18:14:49Z

Mayank will mark the addressed comments as resolved, then reviewers will move forward

maheshwari-mayank · 2021-11-19T19:42:06Z

/azp run

azure-pipelines · 2021-11-19T19:42:11Z

Commenter does not have sufficient privileges for PR 6861 in repo Azure/sonic-buildimage

lguohan · 2021-11-20T05:18:45Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2021-11-20T05:18:56Z

Azure Pipelines successfully started running 1 pipeline(s).

praveen-li

LGTM, thx for making the changes.

[yang_models]: Update extension yang and types yang with new yang ext…

d9efbf2

…ensions and types respectively.

maheshwari-mayank requested a review from lguohan as a code owner February 23, 2021 11:17

ben-gale added the YANG YANG model related changes label Feb 23, 2021

maheshwari-mayank added 2 commits February 23, 2021 22:58

[yang_models]:Update revision-date in import statement

43c8510

[yang-model]: Removed operations container from types yang.

76e9a18

lguohan reviewed Feb 25, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-types.yang Outdated Show resolved Hide resolved

lguohan reviewed Feb 25, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-types.yang Outdated Show resolved Hide resolved

lguohan reviewed Feb 25, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-types.yang Outdated Show resolved Hide resolved

lguohan reviewed Feb 25, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-extension.yang Outdated Show resolved Hide resolved

maheshwari-mayank added 2 commits February 27, 2021 02:04

[yang_models]:Removed revision-date from import statement of sonic-ty…

5cdfcdf

…pes and sonic-extension

{yang_models]: Updated SONiC YANG extensions as per guidelines.

90fe5de

rathnasabapathyv previously approved these changes Mar 16, 2021

View reviewed changes

prvattem reviewed Mar 16, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-extension.yang Outdated Show resolved Hide resolved

src/sonic-yang-models/yang-models/sonic-types.yang Outdated Show resolved Hide resolved

venkatmahalingam reviewed Mar 16, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-extension.yang Outdated Show resolved Hide resolved

venkatmahalingam reviewed Mar 16, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-types.yang Show resolved Hide resolved

venkatmahalingam reviewed Mar 16, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-device_metadata.yang Show resolved Hide resolved

venkatmahalingam reviewed Mar 16, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-extension.yang Outdated Show resolved Hide resolved

[yang_models]: Updated extensions and types yang models as per review…

9f814e3

… comments.

maheshwari-mayank dismissed rathnasabapathyv’s stale review via 9f814e3 March 17, 2021 12:34

mhampasagar previously approved these changes Mar 18, 2021

View reviewed changes

rathnasabapathyv previously approved these changes Mar 18, 2021

View reviewed changes

prvattem previously approved these changes Mar 18, 2021

View reviewed changes

maheshwari-mayank dismissed mhampasagar’s stale review via 7fc7614 May 3, 2021 10:09

maheshwari-mayank and others added 3 commits May 3, 2021 15:44

Merge branch 'master' into extension-yang

65b59d7

[yang_models] Resolved Conflicts

be95a38

[yang_models] Resolved conflicts

22c53a4

praveen-li requested changes May 27, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-extension.yang Show resolved Hide resolved

src/sonic-yang-models/yang-models/sonic-extension.yang Outdated Show resolved Hide resolved

src/sonic-yang-models/yang-models/sonic-types.yang Show resolved Hide resolved

maheshwari-mayank and others added 2 commits May 27, 2021 22:20

[yang_models] Updated sonic extensions yang.

70c1e40

Merge branch 'master' into extension-yang

66f303e

lguohan mentioned this pull request Oct 7, 2021

[sonic-yang]: introduce yang template for cvl yang #8880

Merged

5 tasks

maheshwari-mayank and others added 6 commits October 29, 2021 12:35

Merge branch 'master' into extension-yang

19f5a43

Reverting changes in sonic-acl.yang to merge properly.

23817df

Merge branch 'master' of https://github.com/Azure/sonic-buildimage in…

48e0b9c

…to Azure-master

Merge branch 'Azure-master' into extension-yang

d5215c1

Removed CVL specific yang extensions.

fc438bd

Sonic-mgmt-common already has CVL specific extensions. External yangs generated from templates will be copied to sonic-mgmt-common repo.

Added CVL specific extensions to jinja template and moved extension y…

c04d17b

…ang j2 file to yang-template directory.

[YANG] Added CVL specific type and moved sonic-types to j2 template.

3c310ab

maheshwari-mayank requested a review from qiluo-msft as a code owner November 19, 2021 09:30

lguohan approved these changes Nov 20, 2021

View reviewed changes

praveen-li approved these changes Nov 23, 2021

View reviewed changes

lguohan merged commit 5f235a9 into sonic-net:master Nov 23, 2021

Conversation

maheshwari-mayank commented Feb 23, 2021 • edited by zhangyanzhao Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

ghost commented Feb 23, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arlakshm commented Feb 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maheshwari-mayank commented Mar 18, 2021

Uh oh!

maheshwari-mayank commented Mar 18, 2021

Uh oh!

anand-kumar-subramanian commented Mar 19, 2021

Uh oh!

anand-kumar-subramanian commented Mar 24, 2021

Uh oh!

arlakshm commented Mar 24, 2021

Uh oh!

anand-kumar-subramanian commented Apr 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhangyanzhao commented Sep 2, 2021

Uh oh!

zhangyanzhao commented Sep 2, 2021

Uh oh!

zhangyanzhao commented Sep 16, 2021

Uh oh!

zhangyanzhao commented Sep 30, 2021

Uh oh!

zhangyanzhao commented Oct 7, 2021

Uh oh!

zhangyanzhao commented Nov 18, 2021

Uh oh!

maheshwari-mayank commented Nov 19, 2021

Uh oh!

azure-pipelines bot commented Nov 19, 2021

Uh oh!

lguohan commented Nov 20, 2021

Uh oh!

azure-pipelines bot commented Nov 20, 2021

Uh oh!

praveen-li left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

maheshwari-mayank commented Feb 23, 2021 •

edited by zhangyanzhao

Loading

ghost commented Feb 23, 2021 •

edited by ghost

Loading