[DPB|master] Update Dynamic Port Breakout Logic for flexible alias support a… by samaity · Pull Request #6831 · sonic-net/sonic-buildimage

samaity · 2021-02-20T00:21:21Z

Signed-off-by: Sangita Maity samaity@linkedin.com

Why I did it

To fix DPB| wrong aliases for interfaces issue, implimented flexible alias support design doc

[dpb|config] Fix the validation logic of breakout mode depends on this

How I did it

Removed "alias_at_lanes" from port-configuration file(i.e. platfrom.json)
Added dictionary to "breakout_modes" values. This defines the breakout modes available on the platform for this parent port, and it maps to the alias list. The alias list presents the alias names for individual ports in order under this breakout mode.

{
    "interfaces": {
        "Ethernet0": {
            "index": "1,1,1,1",
            "lanes": "0,1,2,3",
            "breakout_modes": {
                "1x100G[40G]": ["Eth1"],
                "2x50G": ["Eth1/1", "Eth1/2"],
                "4x25G[10G]": ["Eth1/1", "Eth1/2", "Eth1/3", "Eth1/4"],
                "2x25G(2)+1x50G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"],
                "1x50G(2)+2x25G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"]
            }
        }
}

How to verify it

config interface breakout

Which release branch to backport (provide reason below if selected)

201811
201911
202006
202012

…nd related Test cases Signed-off-by: Sangita Maity <samaity@linkedin.com>

src/sonic-config-engine/portconfig.py

Signed-off-by: Sangita Maity <samaity@linkedin.com>

lguohan · 2021-02-22T21:42:29Z

@samaity , what is the build issue?

platform/vs/docker-sonic-vs/platform.json

device/celestica/x86_64-cel_seastone-r0/platform.json

yxieca · 2021-02-22T21:56:08Z

There seems to be a systematic error with the naming when breakout was done at half speeds (50G).

E.g. when 2 interfaces break to 50G, the second interface should be Ethx/3 or etpxc

This error is also noticed in PR comment.

yxieca

Please fix the breakout numbering when half speed breakout is involved.

zhenggen-xu · 2021-02-23T01:21:51Z

There seems to be a systematic error with the naming when breakout was done at half speeds (50G).

E.g. when 2 interfaces break to 50G, the second interface should be Ethx/3 or etpxc

This error is also noticed in PR comment.

Actually according to this doc, which you submitted, it was etpxb instead of etpxc: :-)
https://github.com/Azure/SONiC/blob/master/doc/sonic-port-name.md

Anyway, this alias list is really for box vendor or user to define and we don't limit to anything as for the design. And for us, we prefer to have 1/1 and 1/2. and this is inline with one of the traditional vendors.

device/barefoot/x86_64-accton_wedge100bf_32x-r0/platform.json

device/barefoot/x86_64-accton_wedge100bf_65x-r0/platform.json

samaity · 2021-02-23T19:17:46Z

To give a brief, we fixed the breakout numbering when a half-speed breakout (i.e. 2x50G) is involved for Barefoot and VS platform by modifying platform.json as requested

Barefoot

"breakout_modes": {
                "1x100G[40G]": ["Ethernet0"],
                "2x50G": ["Ethernet0", "Ethernet2"],

vs

"breakout_modes": {
                "1x100G[40G]": ["fortyGigE0/0"],
                "2x50G": ["fortyGigE0/0", "fortyGigE0/2"],

For other platforms, we are keeping it as it is. Kindly let us know if any modification is needed after the latest one. Thanks!

…form Signed-off-by: Sangita Maity <samaity@linkedin.com>

samaity · 2021-02-25T06:28:55Z

retest this please

lguohan · 2021-02-25T17:36:23Z

can you update the sonic utilties since the fix is merged?

jleveque · 2021-02-25T18:22:36Z

can you update the sonic utilties since the fix is merged?

I have advanced the submodule further in my PR: #6874

jleveque · 2021-02-25T19:41:20Z

@samaity: There are still build failures. Can you please check?

addressed

…pport a… (sonic-net#6831) To fix [DPB| wrong aliases for interfaces](sonic-net#6024) issue, implimented flexible alias support [design doc](sonic-net/SONiC#749) > [[dpb|config] Fix the validation logic of breakout mode](sonic-net/sonic-utilities#1440) depends on this 1. Removed `"alias_at_lanes"` from port-configuration file(i.e. platfrom.json) 2. Added dictionary to "breakout_modes" values. This defines the breakout modes available on the platform for this parent port, and it maps to the alias list. The alias list presents the alias names for individual ports in order under this breakout mode. ``` { "interfaces": { "Ethernet0": { "index": "1,1,1,1", "lanes": "0,1,2,3", "breakout_modes": { "1x100G[40G]": ["Eth1"], "2x50G": ["Eth1/1", "Eth1/2"], "4x25G[10G]": ["Eth1/1", "Eth1/2", "Eth1/3", "Eth1/4"], "2x25G(2)+1x50G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"], "1x50G(2)+2x25G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"] } } } ``` `config interface breakout` Signed-off-by: Sangita Maity <samaity@linkedin.com> device/mellanox/x86_64-mlnx_msn2700-r0/platform.json

…pport a… (sonic-net#6831) To fix [DPB| wrong aliases for interfaces](sonic-net#6024) issue, implimented flexible alias support [design doc](sonic-net/SONiC#749) > [[dpb|config] Fix the validation logic of breakout mode](sonic-net/sonic-utilities#1440) depends on this #### How I did it 1. Removed `"alias_at_lanes"` from port-configuration file(i.e. platfrom.json) 2. Added dictionary to "breakout_modes" values. This defines the breakout modes available on the platform for this parent port, and it maps to the alias list. The alias list presents the alias names for individual ports in order under this breakout mode. ``` { "interfaces": { "Ethernet0": { "index": "1,1,1,1", "lanes": "0,1,2,3", "breakout_modes": { "1x100G[40G]": ["Eth1"], "2x50G": ["Eth1/1", "Eth1/2"], "4x25G[10G]": ["Eth1/1", "Eth1/2", "Eth1/3", "Eth1/4"], "2x25G(2)+1x50G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"], "1x50G(2)+2x25G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"] } } } ``` #### How to verify it `config interface breakout` Signed-off-by: Sangita Maity <samaity@linkedin.com>

samaity requested review from jleveque and lguohan as code owners February 20, 2021 00:21

samaity mentioned this pull request Feb 20, 2021

[dpb|config] Fix the validation logic of breakout mode sonic-net/sonic-utilities#1440

Merged

[DPB] Update Dynamic Port Breakout Logic for flexible alias support a…

c536888

…nd related Test cases Signed-off-by: Sangita Maity <samaity@linkedin.com>

samaity force-pushed the 6024_main_fix branch from 8e78a56 to c536888 Compare February 20, 2021 00:43

zhenggen-xu reviewed Feb 20, 2021

View reviewed changes

src/sonic-config-engine/portconfig.py Show resolved Hide resolved

src/sonic-config-engine/portconfig.py Outdated Show resolved Hide resolved

src/sonic-config-engine/portconfig.py Outdated Show resolved Hide resolved

src/sonic-config-engine/portconfig.py Outdated Show resolved Hide resolved

Sangita Maity added 2 commits February 20, 2021 16:08

updated few variables name and removed unnecessary lines.

9877186

Signed-off-by: Sangita Maity <samaity@linkedin.com>

Added sample cases to support more alternative speeds and verify regex

1a02b58

Signed-off-by: Sangita Maity <samaity@linkedin.com>

zhenggen-xu added Port Breakout 🔱 Request for 202012 Branch labels Feb 21, 2021

zhenggen-xu previously approved these changes Feb 21, 2021

View reviewed changes

lguohan reviewed Feb 22, 2021

View reviewed changes

platform/vs/docker-sonic-vs/platform.json Outdated Show resolved Hide resolved

lguohan reviewed Feb 22, 2021

View reviewed changes

platform/vs/docker-sonic-vs/platform.json Outdated Show resolved Hide resolved

yxieca reviewed Feb 22, 2021

View reviewed changes

device/celestica/x86_64-cel_seastone-r0/platform.json Show resolved Hide resolved

yxieca previously requested changes Feb 22, 2021

View reviewed changes

dmytroxshevchuk reviewed Feb 23, 2021

View reviewed changes

device/barefoot/x86_64-accton_wedge100bf_32x-r0/platform.json Outdated Show resolved Hide resolved

device/barefoot/x86_64-accton_wedge100bf_65x-r0/platform.json Outdated Show resolved Hide resolved

samaity dismissed zhenggen-xu’s stale review via ecc6dad February 23, 2021 19:10

[BAREFOOT|VS] Changed the 2x50G alias values for Barefoot and VS Plat…

a4e3c74

…form Signed-off-by: Sangita Maity <samaity@linkedin.com>

samaity force-pushed the 6024_main_fix branch from ecc6dad to a4e3c74 Compare February 23, 2021 23:45

yxieca self-requested a review February 24, 2021 06:19

samaity mentioned this pull request Feb 25, 2021

[sonic-utilities] Update submodule #6874

Closed

jleveque mentioned this pull request Feb 25, 2021

[sonic-swss] Advance submodule #6789

Closed

4 tasks

update sonic-utilities submodule

4dbfef7

samaity force-pushed the 6024_main_fix branch from a288629 to 4dbfef7 Compare February 26, 2021 02:01

lguohan approved these changes Feb 26, 2021

View reviewed changes

lguohan merged commit 18263c9 into sonic-net:master Feb 26, 2021

This was referenced Mar 1, 2021

Revert "[DPB] [Mellanox] added capability files for SN4600 platform (… #6929

Closed

[utilities] Update submodule #6888

Closed

vaibhavhd mentioned this pull request Mar 3, 2021

warm-reboot throws many errors before going for a reboot #6840

Open

dmytroxshevchuk mentioned this pull request May 12, 2021

Parse platform.json, hwsku.json for generate minigraph sonic-net/sonic-mgmt#2887

Merged

3 tasks

zhenggen-xu removed the Request for 202012 Branch label May 12, 2021

Conversation

samaity commented Feb 20, 2021

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lguohan commented Feb 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yxieca commented Feb 22, 2021

Uh oh!

yxieca left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhenggen-xu commented Feb 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samaity commented Feb 23, 2021

Uh oh!

samaity commented Feb 25, 2021

Uh oh!

lguohan commented Feb 25, 2021

Uh oh!

jleveque commented Feb 25, 2021

Uh oh!

jleveque commented Feb 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yxieca left a comment •

edited

Loading

zhenggen-xu commented Feb 23, 2021 •

edited

Loading