.gitmodules: Fix make init#6828
Merged
lguohan merged 1 commit intosonic-net:masterfrom Feb 23, 2021
donNewtonAlpha:fix-on-master
Merged
.gitmodules: Fix make init#6828lguohan merged 1 commit intosonic-net:masterfrom donNewtonAlpha:fix-on-master
lguohan merged 1 commit intosonic-net:masterfrom
donNewtonAlpha:fix-on-master
Conversation
* fix url for * submodule "platform/mellanox/hw-management/hw-mgmt" * remove trailing / from url Signed-off-by: Don Newton [email protected]
jleveque
approved these changes
Feb 20, 2021
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Thanks for the fix. I'm surprised we haven't noticed any issues to date. Must be due to differences in our environments. According to the Git documentation, the path must not end with a trailing slash.
Contributor
Author
It doesn't actually break |
yxieca
pushed a commit
that referenced
this pull request
Feb 23, 2021
* remove trailing / from url for submodule "platform/mellanox/hw-management/hw-mgmt" Signed-off-by: Don Newton [email protected]
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
* remove trailing / from url for submodule "platform/mellanox/hw-management/hw-mgmt" Signed-off-by: Don Newton [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Don Newton [email protected]
Why I did it
During make init submodule`` "platform/mellanox/hw-management/hw-mgmt" fails to clone due to trailing / on the url
How I did it
Removed the trailing /
How to verify it
make initand look for errorsWhich release branch to backport (provide reason below if selected)
ONF is using the 202012 branch as the base for our effort
Description for the changelog
Correct the url line for submodule "platform/mellanox/hw-management/hw-mgmt"
A picture of a cute animal (not mandatory but encouraged)