[teamd]: Increase wait timeout for teamd docker stop to clean Port channels.

[shlomibitton]

Signed-off-by: Shlomi Bitton [email protected]

- Why I did it
Following this PR #6537
Increase wait timeout for teamd docker stop to clean Port channels.
Fixes #6199

- How I did it
Changed the container timeout on stop() function for container template.

- How to verify it

- Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[liat-grozovik]

@abdosi please review. we believe this is needed for production

[nazariig]

@shlomibitton please have a look at this: #6648

[abdosi]

@judyjoseph can you review/approve this ?

[judyjoseph]

@shlomibitton please have a look at this: #6648

@shlomibitton This PR (#6648) was introduced to fix #6503. Have you verified this takes care of this scenario , would be great if you add the verification details in the description.

Additionally I was not able to repro this issue #6199 in 201911, were you seeing it ?

[liat-grozovik]

Hi Yes we did, we were able to reproduce it when we have a ~80 port channel and each with IP address. It was also verified on the reproduction environment and found to be working. From: judyjoseph <[email protected]> Sent: Tuesday, February 16, 2021 10:06 PM To: Azure/sonic-buildimage <[email protected]> Cc: Liat Grozovik <[email protected]>; Comment <[email protected]> Subject: Re: [Azure/sonic-buildimage] [teamd]: Increase wait timeout for teamd docker stop to clean Port channels. (#6757) @shlomibitton<https://github.com/shlomibitton> please have a look at this: #6648<#6648> @shlomibitton<https://github.com/shlomibitton> This PR (#6648<#6648>) was introduced to fix #6503<#6503>. Have you verified this takes care of this scenario , would be great if you add the verification details in the description. Additionally I was not able to repro this issue #6199<#6199> in 201911, were you seeing it ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#6757 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA2KCYTHITDTRE52GWDS7LF35ANCNFSM4XNTA4MQ>.

[shlomibitton]

@nazariig @judyjoseph this PR #6648 is basically does the same thing only for teamd docker.
The current PR will increase the timeout for all dockers which I find reasonable to avoid future issues like this.
Both PR's will fix the issue.

[judyjoseph]

@shlomibitton Thanks for pointing this out. Would prefer to increase timeout specific to teamd docker as done in #6648. Increasing the timeout could change behavior of time sensitive use cases like warm boot.

[liat-grozovik]

@judyjoseph is there a PR like #6648 already in master/202012 (thus closing this one should be done) or you wish this one to be modified ?
@liat-grozovik, we can go ahead with #6648. I will add the reference of this PR there. Can close this one then - thanks.

[abdosi]

closing this.