Change the order of stopping dependent services of SWSS on 201911#6756
Merged
abdosi merged 1 commit intosonic-net:201911from Feb 18, 2021
shlomibitton:shlomi_stop_teamd_201911
Merged
Change the order of stopping dependent services of SWSS on 201911#6756abdosi merged 1 commit intosonic-net:201911from shlomibitton:shlomi_stop_teamd_201911
abdosi merged 1 commit intosonic-net:201911from
shlomibitton:shlomi_stop_teamd_201911
Conversation
Signed-off-by: Shlomi Bitton <[email protected]>
liat-grozovik
approved these changes
Feb 14, 2021
Collaborator
|
@abdosi please review. we believe this is needed for 201911 production env. |
Contributor
|
@yxieca and @judyjoseph please review this. |
yxieca
approved these changes
Feb 16, 2021
Contributor
|
The change looks ok, Could you add the results you observed with and without this change. thanks. |
Collaborator
|
@judyjoseph the comment was updated with more information and how it was verified. please let us know if something is missing, otherwise we strongly suggest to take it to 201911 |
judyjoseph
approved these changes
Feb 18, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton [email protected]
- Why I did it
When large number of port channels (more than 64) is configured, a config reload command might ends with not all port channel configured and up. Further debug shows that unloading the port channels on the ASIC driver take a lot of time.
With the change, deleting all port channels before the syncd restart will free resources better and the ASIC driver will unload all netdev fast and the operation will execute properly.
- How I did it
Change the order of dependent services of SWSS.
- How to verify it
Before the fix:
After the fix:
Which release branch to backport (provide reason below if selected)
[ ] 201811
[ ] 201911
[ ] 202006
[ ] 202012
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)