[barefoot][sonic-platform] Fix get_system_eeprom_info and refactor eeprom.py#6739
Merged
lguohan merged 2 commits intosonic-net:masterfrom Feb 11, 2021
Merged
Conversation
vboykox
force-pushed
the
fix_get_syseemprom_info
branch
from
30323dd to
acdbe97
Compare
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
vboykox
force-pushed
the
fix_get_syseemprom_info
branch
4 times, most recently
from
3d23ec2 to
66cca3f
Compare
|
This pull request introduces 2 alerts when merging 66cca3f46f0c8689b282bdcde1b668a87d443b7b into c54a03f - view on LGTM.com new alerts:
|
vboykox
force-pushed
the
fix_get_syseemprom_info
branch
2 times, most recently
from
a67a32c to
2f7fcc5
Compare
vboykox
changed the title
Member
Author
irrelevant for this pr, changes that were causing this are moved into separate pr |
vboykox
changed the title
akokhan
reviewed
Feb 11, 2021
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/eeprom.py
Show resolved
Hide resolved
akokhan
reviewed
Feb 11, 2021
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/eeprom.py
Show resolved
Hide resolved
akokhan
reviewed
Feb 11, 2021
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/eeprom.py
Show resolved
Hide resolved
vboykox
force-pushed
the
fix_get_syseemprom_info
branch
from
c976504 to
6d080d5
Compare
akokhan
approved these changes
Feb 11, 2021
Member
Author
jleveque
approved these changes
Feb 11, 2021
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
…prom.py (#6739) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com
- Why I did it
sonic-platform fixups for Barefoot
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)