DellEMC S6100: Watchdog - Make arm() method Python3 compatible#6734
Merged
lguohan merged 1 commit intosonic-net:masterfrom Feb 10, 2021
Merged
Conversation
ArunSaravananBalachandran
changed the title
jleveque
approved these changes
Feb 10, 2021
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
To make watchdog.arm() method python3 compatible in DellEMC S6100.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
To make watchdog.arm() method python3 compatible in DellEMC S6100.
- How I did it
Use
bytesinstead ofstras input for os.write().- How to verify it
Load sonic_platform package and verify no errors are seen when watchdog.arm() method is invoked.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
DellEMC S6100: Watchdog - Make arm() method Python3 compatible
- A picture of a cute animal (not mandatory but encouraged)