BRCM SAI 4.3.0.10-5 : Fix for ACL entry set attribute for IN_PORTS f…#6718
Merged
lguohan merged 1 commit intosonic-net:masterfrom Feb 8, 2021
vmittal-msft:acl_entry_fix
Merged
BRCM SAI 4.3.0.10-5 : Fix for ACL entry set attribute for IN_PORTS f…#6718lguohan merged 1 commit intosonic-net:masterfrom vmittal-msft:acl_entry_fix
lguohan merged 1 commit intosonic-net:masterfrom
vmittal-msft:acl_entry_fix
Conversation
lguohan
approved these changes
Feb 8, 2021
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
… IN_PORTS for TD3 (#6718) ACL entry set attribute updates all the entries in the table. The correct behavior is to set the attribute on single entry. - How I did it Current SDK code, while setting the new attribute, is going through all the entries and updating it. Added a logic to check for requested entry and only allow for that ACL entry. A case has filed with BRCM. Once an official fix is provided by BRCM, we will then remove this in house fix and apply the official fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or TD3
- Why I did it
ACL entry set attribute updates all the entries in the table. The correct behavior is to set the attribute on single entry.
- How I did it
Current SDK code, while setting the new attribute, is going through all the entries and updating it. Added a logic to check for requested entry and only allow for that ACL entry.
A case has filed with BRCM. Once an official fix is provided by BRCM, we will then remove this in house fix and apply the official fix.
- How to verify it
Try setting the attribute on single ACL entry on TD3 platform a nd it should updated that attribute for requested entry only.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Fix for ACL entry set attribute for MATCH_IN_PORTS
- A picture of a cute animal (not mandatory but encouraged)