[syncd-rpc] Install Libboost Atomic 1.71, Libqtcore And Libqtnetwork#6689
Merged
lguohan merged 2 commits intosonic-net:masterfrom Feb 10, 2021
Merged
Conversation
When Building syncd-rpc, libthrift has dependency on libboost-atomic1.71.0, however the debian packager install version 1.67 instead. This PR preinstalls libboost-atomic v 1.71 to avoid falling back to v 1.67. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Collaborator
|
can you install this libraray on all syncd-rpc docker based on buster? |
Collaborator
|
also can you link this pr with the issue to resolve? |
Collaborator
|
any update on this? |
tahmed-dev
changed the title
Contributor
Author
verified the fix on target. |
lguohan
approved these changes
Feb 10, 2021
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
…6689) When Building syncd-rpc, libthrift has dependency on libboost-atomic1.71.0, however the debian packager install version 1.67 instead. This PR preinstalls libboost-atomic v 1.71 to avoid falling back to v 1.67. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Building syncd-rpc, libthrift has dependency on libboost-atomic1.71.0, libqt5core5a,
and libqt5network5 however debian packager fails to resolve the dependencies. It instead
installs libthrift from debian along with its dependencies which result in symbols not found.
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
closes #6622
resolves #6622
Please provide the following information:
-->
- Why I did it
resolve issue loading sync-rpc
- How I did it
ensured dependecies are installed before installing libthrift
- How to verify it
load docker sync-rpc on target and there should not be errors find symbol thrift server symbol
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)