[docker-ptf]: consolidate docker-ptf build#6540
Merged
lguohan merged 3 commits intosonic-net:masterfrom Jan 27, 2021
Merged
Conversation
Contributor
|
retest baseimage please |
- combine docker-ptf-saithrift into docker-ptf docker - build docker-ptf under platform vs - remove docker-ptf for other platforms Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
Collaborator
Author
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Jan 27, 2021
MuLinForest
added a commit
to MuLinForest/sonic-mgmt
that referenced
this pull request
Feb 2, 2021
What is the motivation for this PR? When I try to build target/docker-ptf.gz according to the document, it will show "No rule to make target 'target/docker-ptf.gz". How did you do it? According to sonic-net/sonic-buildimage#6540, the platform option to build docker-ptf.gz should change to vs. How did you verify/test it? After changed the platform option to vs, target/docker-ptf.gz can be successfully built.
3 tasks
lguohan
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Feb 2, 2021
What is the motivation for this PR? When I try to build target/docker-ptf.gz according to the document, it will show "No rule to make target 'target/docker-ptf.gz". How did you do it? According to sonic-net/sonic-buildimage#6540, the platform option to build docker-ptf.gz should change to vs. How did you verify/test it? After changed the platform option to vs, target/docker-ptf.gz can be successfully built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
- How I did it
see the pr
- How to verify it
build docker-ptf
depends on opencomputeproject/SAI#1184
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)