Skip to content

[device/accton][as7816-64x] Fix memory leakage on accton fan monitor #6529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roylee123 wants to merge 1 commit into from
Closed

[device/accton][as7816-64x] Fix memory leakage on accton fan monitor #6529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions platform/broadcom/sonic-platform-modules-accton/as7816-64x/utils/accton_as7816_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ class accton_as7816_monitor(object):

def __init__(self, log_file, log_level):
"""Needs a logger and a logger level."""

self.thermal = ThermalUtil()
self.fan = FanUtil()
# set up logging to file
logging.basicConfig(
filename=log_file,
Expand Down Expand Up @@ -83,8 +86,8 @@ def manage_fans(self):
4: [max_duty, 57000, sys.maxsize],
}

thermal = ThermalUtil()
fan = FanUtil()
thermal = self.thermal
fan = self.fan
for x in range(fan.get_idx_fan_start(), fan.get_num_fans()+1):
fan_status = fan.get_fan_status(x)
if fan_status is None:
Expand Down