[pmon] Run ledd using python3 unless excluded#6528
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 22, 2021
Merged
Conversation
jleveque
approved these changes
Jan 21, 2021
Collaborator
|
az pipeline test passed. |
lguohan
pushed a commit
that referenced
this pull request
Jan 22, 2021
**- Why I did it** Ledd is the last daemon that is not enabled to run in python3. Even though there is a plan to deprecate this daemon and to replace it by something else it's one simple step toward python2 deprecation. **- How I did it** Changed the `command=` line for `ledd` in the `supervisord` configuration of `pmon`. Copied what was done for other daemons. **- How to verify it** Booting a product that has a `led_control.py` should now show the ledd running in python3. I ran `python3 -m pylint` on all `led_control.py` plugin which means that most of them should be python3 compliant. There is however still a risk that some might not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Ledd is the last daemon that is not enabled to run in python3.
Even though there is a plan to deprecate this daemon and to replace it by something else it's one simple step toward python2 deprecation.
- How I did it
Changed the
command=line forleddin thesupervisordconfiguration ofpmon.Copied what was done for other daemons.
- How to verify it
Booting a product that has a
led_control.pyshould now show the ledd running in python3.I ran
python3 -m pylinton allled_control.pyplugin which means that most of them should be python3 compliant.There is however still a risk that some might not work.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Run ledd in python3 unless excluded by the platform