[pcie.yaml] Move pcie configuration file path to platform directory#6475
Merged
sujinmkang merged 10 commits intosonic-net:masterfrom Feb 21, 2021
Merged
[pcie.yaml] Move pcie configuration file path to platform directory#6475sujinmkang merged 10 commits intosonic-net:masterfrom
sujinmkang merged 10 commits intosonic-net:masterfrom
Conversation
jleveque
suggested changes
Jan 18, 2021
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Please make PR title more descriptive.
Also, this PR removes the systemd timer file, but there is no mention of that in the PR description. Please also enhance the PR description to detail all changes in the PR.
Collaborator
|
can you have good description and pr title? |
sujinmkang
changed the title
sujinmkang
changed the title
Collaborator
Author
|
@jleveque can you hold your review for now, I'm verifying the changes with pmon and utilities prs again. |
Contributor
|
@sujinmkang: Once all of the related PRs for this change eventually merge, please be sure to update https://github.com/Azure/SONiC/wiki/Porting-Guide to reflect the path changes. |
…ded to multi-user.target to start during the boot
Collaborator
Author
|
retest vsimage please |
sujinmkang
changed the title
Collaborator
Author
|
@jleveque is the PR title still not clear? |
Contributor
The title and description are much better now. Thanks! |
jleveque
previously approved these changes
Feb 4, 2021
jleveque
reviewed
Feb 5, 2021
jleveque
previously approved these changes
Feb 9, 2021
Collaborator
Author
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
there is a mistake here. /x86_64-cel_e1031-r0pcie.yaml |
Collaborator
|
@sujinmkang , can you fix? |
Collaborator
Author
|
@lguohan can you please review this again? |
jleveque
approved these changes
Feb 10, 2021
sujinmkang
dismissed
lguohan’s stale review
I already addressed his review comment but didn't get any response for long days.
Collaborator
Author
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 23, 2021
yxieca
pushed a commit
that referenced
this pull request
Mar 4, 2021
…6475) - Why I did it The pcie configuration file location is under plugin directory not under platform directory. #6437 - How I did it Move all pcie.yaml configuration file from plugin to platform directory. Remove unnecessary timer to start pcie-check.service Move pcie-check.service to sonic-host-services - How to verify it Verify on the device
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…onic-net#6475) - Why I did it The pcie configuration file location is under plugin directory not under platform directory. sonic-net#6437 - How I did it Move all pcie.yaml configuration file from plugin to platform directory. Remove unnecessary timer to start pcie-check.service Move pcie-check.service to sonic-host-services - How to verify it Verify on the device
lolyu
pushed a commit
to lolyu/sonic-buildimage
that referenced
this pull request
Sep 13, 2021
…onic-net#6475) - Why I did it The pcie configuration file location is under plugin directory not under platform directory. sonic-net#6437 - How I did it Move all pcie.yaml configuration file from plugin to platform directory. Remove unnecessary timer to start pcie-check.service Move pcie-check.service to sonic-host-services - How to verify it Verify on the device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
The pcie configuration file location is under plugin directory not under platform directory.
#6437
- How I did it
- How to verify it
Verify on the device.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)