Update swi-tools in buster Dockerfile#6414
Merged
jleveque merged 1 commit intosonic-net:masterfrom Jan 13, 2021
Merged
Conversation
Use the python3 version by default
jleveque
approved these changes
Jan 11, 2021
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
Fixed swi-tools code to work with `python3` Updated the version of swi-tools downloaded by the `sonic-slave-buster/Dockerfile.j2` Other Dockerfiles still use the `python2` version, though swi-tools is not used within the stretch builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
This is part of the python2 to python3 migration effort.
- How I did it
Fixed swi-tools code to work with
python3Updated the version of swi-tools downloaded by the
sonic-slave-buster/Dockerfile.j2Other Dockerfiles still use the
python2version, though swi-tools is not used within the stretch builder.- How to verify it
Build an image with
SONIC_ENABLE_IMAGE_SIGNATURE = yand verify that build passes.Install the image on a secureboot enabled product to verify that it works.
- Which release branch to backport (provide reason below if selected)
It is pretty much a harmless change that push python2 to python3 conversion closer to the finish line.
- Description for the changelog
Update the swi-tools version used by buster Dockerfile